Skip to content

Media: Send array values from the upload pipeline as arrays - #15146

Open
aryanjasala wants to merge 1 commit into
WordPress:trunkfrom
aryanjasala:fix/media-pipeline-array-form-data
Open

aryanjasala wants to merge 1 commit into
WordPress:trunkfrom
aryanjasala:fix/media-pipeline-array-form-data

Conversation

@aryanjasala

Copy link
Copy Markdown

When several registered image sizes have the same dimensions, the Media Library upload pipeline sideloads one file for all of them and passes their names as an array in image_size. flattenFormData() in media-upload-pipeline.js appended that array as the string a,b, so the sideload endpoint returned 400 and those sizes were never created.

This makes flattenFormData() recurse into arrays as well as plain objects, the same as flattenFormData() in the media-utils package since WordPress/gutenberg#82353.

Testing: with two sizes registered at 320 by 320, uploading a JPEG from Media > Add New on 7.2-beta3-64990 returned 400 for one sideload and created neither size. With this change, every sideload returned 200 and both sizes are in the attachment metadata.

Trac ticket: https://core.trac.wordpress.org/ticket/66412

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Writing the patch and drafting this description. I reproduced the bug and tested the fix myself.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

When several registered image sizes have the same dimensions, the upload pipeline sideloads one file for all of them and passes their names as an array in `image_size`. `flattenFormData()` in `media-upload-pipeline.js` turned that array into the string `a,b`, so the sideload endpoint rejected it and those sizes were never created.

This handles arrays the same way as the `flattenFormData()` in the media-utils package, which was fixed in Gutenberg PR 82353.

See #66412.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aryanjasala.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant