Repository navigation
Media: Send array values from the upload pipeline as arrays - #15146
aryanjasala wants to merge 1 commit into
Conversation
When several registered image sizes have the same dimensions, the upload pipeline sideloads one file for all of them and passes their names as an array in `image_size`. `flattenFormData()` in `media-upload-pipeline.js` turned that array into the string `a,b`, so the sideload endpoint rejected it and those sizes were never created. This handles arrays the same way as the `flattenFormData()` in the media-utils package, which was fixed in Gutenberg PR 82353. See #66412.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
When several registered image sizes have the same dimensions, the Media Library upload pipeline sideloads one file for all of them and passes their names as an array in
image_size.flattenFormData()inmedia-upload-pipeline.jsappended that array as the stringa,b, so the sideload endpoint returned 400 and those sizes were never created.This makes
flattenFormData()recurse into arrays as well as plain objects, the same asflattenFormData()in the media-utils package since WordPress/gutenberg#82353.Testing: with two sizes registered at 320 by 320, uploading a JPEG from Media > Add New on 7.2-beta3-64990 returned 400 for one sideload and created neither size. With this change, every sideload returned 200 and both sizes are in the attachment metadata.
Trac ticket: https://core.trac.wordpress.org/ticket/66412
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Writing the patch and drafting this description. I reproduced the bug and tested the fix myself.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.