Skip to content

Menus: Fix expanding menu items on touch devices - #15327

Open
sarequl wants to merge 1 commit into
WordPress:trunkfrom
sarequl:fix/62451-menu-touch-tap
Open

sarequl wants to merge 1 commit into
WordPress:trunkfrom
sarequl:fix/62451-menu-touch-tap

Conversation

@sarequl

@sarequl sarequl commented Nov 1, 2026

Copy link
Copy Markdown

Fixes the classic Menus disclosure arrow on touch devices.

See https://core.trac.wordpress.org/ticket/62451

What

On touch devices, tapping a menu item's disclosure arrow (.item-edit) only expanded the item when the finger stayed perfectly still. Any movement, even 1px, started a drag and the settings panel never opened.

Why

The whole .menu-item-handle is the sortable handle, including the arrow. jQuery UI Touch Punch treats any touchmove on the handle as a drag, cancels touchstart, and suppresses the click the browser would have fired for the tap.

How

A capture-phase touchstart listener on #menu-to-edit stops propagation when the touch starts inside .item-edit, so Touch Punch never sees it and the browser fires the click. The listener is delegated, so items added via AJAX are covered. Reordering from the rest of the handle is unchanged.

Testing Instructions

  1. On a touch device (or mobile emulation), open Appearance → Menus with a menu that has a few items.
  2. Tap the disclosure arrow on an item, allowing about 1px of finger movement. The item expands and its settings appear. On trunk this fails; a perfectly still tap works.
  3. Drag an item by its handle to reorder it. The order still changes.
  4. With a mouse, click the arrow; it expands. Focus the arrow and press Enter; it toggles.

The keyboard and mouse paths are unchanged. npm run build, PHPStan, and eslint are clean. composer lint reports only the pre-existing trunk baseline; no PHP files are touched.

Props sukhendu2002 for the diagnosis in comment 19.

Touch Punch treats any touchmove on the sortable handle as a drag and
suppresses the click, so tapping the disclosure arrow with slight finger
movement never opened the item. Keep touches on the edit link from
reaching the sortable so the browser can fire the click.
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sarequl.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant