Skip to content

Quicktags: Honor an empty default button list - #15437

Open
salvatorecorsi wants to merge 1 commit into
WordPress:trunkfrom
salvatorecorsi:fix/30942-quicktags-empty-buttons
Open

salvatorecorsi wants to merge 1 commit into
WordPress:trunkfrom
salvatorecorsi:fix/30942-quicktags-empty-buttons

Conversation

@salvatorecorsi

Copy link
Copy Markdown

Honor an explicit empty list in quicktags( { id: 'my-editor', buttons: '' } ). Quicktags currently treats that value like an omitted setting and adds the default buttons.

The condition now recognizes '' as a specified list while preserving the existing handling of omitted and other falsey values. The list continues to filter built-in buttons only: custom buttons registered with QTags.addButton() and the separate RTL direction control retain their behavior. Toolbar visibility and styling are outside this change.

This follows the earlier patch discussion by gitlost and azaozz on the ticket, refreshed against current trunk with regression coverage.

Trac ticket: https://core.trac.wordpress.org/ticket/30942

Validation

  • Five QUnit tests use the actual Quicktags API and textarea DOM. The original code fails three assertions for the empty list, late custom-button refresh and RTL; the fix passes all 15.
  • Full build, JSHint, scoped JSDoc and JavaScript typecheck pass.
  • The unchanged upstream browser driver passes both complete QUnit pages: 719 assertions in compiled.html and 719 in index.html.
  • The default Grunt QUnit launcher fails with spawn EINVAL on Windows, also reproduced with an independent npm --version spawn. The successful browser run uses a coordinator-only config changing just Chromium's executablePath.

Use of AI Tools

Codex investigated the ticket, authored the patch and tests, ran the recorded checks and performed a separate automated source review. No separate human review by the account owner has taken place.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props salvatorecorsi.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant