Repository navigation
Quicktags: Honor an empty default button list - #15437
salvatorecorsi wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Honor an explicit empty list in
quicktags( { id: 'my-editor', buttons: '' } ). Quicktags currently treats that value like an omitted setting and adds the default buttons.The condition now recognizes
''as a specified list while preserving the existing handling of omitted and other falsey values. The list continues to filter built-in buttons only: custom buttons registered withQTags.addButton()and the separate RTL direction control retain their behavior. Toolbar visibility and styling are outside this change.This follows the earlier patch discussion by gitlost and azaozz on the ticket, refreshed against current trunk with regression coverage.
Trac ticket: https://core.trac.wordpress.org/ticket/30942
Validation
compiled.htmland 719 inindex.html.spawn EINVALon Windows, also reproduced with an independentnpm --versionspawn. The successful browser run uses a coordinator-only config changing just Chromium'sexecutablePath.Use of AI Tools
Codex investigated the ticket, authored the patch and tests, ran the recorded checks and performed a separate automated source review. No separate human review by the account owner has taken place.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.