[bgturner]

✅ Committed in r65282 (e5cb560).

---

Fixes the only booleanAnd.alwaysFalse PHPStan error, in src/wp-admin/themes.php, by declaring the admin globals that the file reads, rather than by changing the condition. The baseline file for the identifier is removed.

// 0 = name, 1 = capability, 2 = file.
if ( 0 === strcmp( $self, $item[2] ) && empty( $parent_file )
	|| $parent_file && $item[2] === $parent_file
) {
	$class = ' current';
}

PHPStan saw $parent_file only as the literal 'themes.php' assigned earlier in the file, so it reported empty( $parent_file ) as never true. That is a false positive: wp-admin/menu-header.php, which wp-admin/admin-header.php loads, passes $parent_file through the parent_file filter, so a plugin can make it empty and reach the first clause. Likewise $self is set in menu-header.php, and $submenu in wp-admin/menu.php, neither of which PHPStan follows across the require chain.

The condition is therefore left exactly as it is in trunk. After the admin-header.php require, the file now declares the globals with a file-scope global statement:

/**
 * @global string $self        The current admin page, set in wp-admin/menu-header.php.
 * @global string $parent_file The parent menu file, filtered in wp-admin/menu-header.php.
 * @global array<string, array<int, array{ 0: string, 1: string, 2: string, 3?: string, 4?: string }>> $submenu The admin submenu items keyed by parent slug, set in wp-admin/menu.php.
 */
global $self, $parent_file, $submenu;

An inline @var is not enough here: with treatPhpDocTypesAsCertain: false, the always-true/false rules use the native type, which only the global statement resets. The @global tags are then applied by tests/phpstan/GlobalDocBlockVisitor.php.

Baseline entries removed for themes.php:

• booleanAnd.alwaysFalse (the whole baseline file, and its includes entry in phpstan.neon.dist)
• booleanAnd.leftAlwaysTrue
• empty.variable for $parent_file
• variable.undefined for $self and $submenu

With the $submenu shape, the level 10 mixed errors in the Appearance submenu loop are also gone. themes.php no longer has any baseline entries.

Original description

Fixes the only booleanAnd.alwaysFalse error and removes tests/phpstan/baselines/booleanAnd.alwaysFalse.neon.

The error

src/wp-admin/themes.php:376
Result of && is always false.

// 0 = name, 1 = capability, 2 = file.
if ( 0 === strcmp( $self, $item[2] ) && empty( $parent_file )
	|| $parent_file && $item[2] === $parent_file
) {
	$class = ' current';
}

$parent_file is assigned once, earlier in this file, to the literal string 'themes.php', and never reassigned before this line. So empty( $parent_file ) can never be true, and the first half of the || -- 0 === strcmp( $self, $item[2] ) && empty( $parent_file ) -- can never be true either, regardless of what $self is.

The fix

Drop the always-false clause. The condition reduces to the half that was actually reachable: $parent_file && $item[2] === $parent_file.

This removes the file's only reference to $self, which also retires a variable.undefined baseline entry for it. To be precise about why: $self is not dead or unassigned code -- it's a legitimate WordPress admin global, set in wp-admin/menu-header.php (required transitively via wp-admin/admin-header.php, itself required earlier in this same file). PHPStan's single-file analysis can't see across that require chain, the same way it can't see $submenu's definition in wp-admin/menu.php. Removing the reference is safe not because $self was unused, but because the clause it was part of is unreachable regardless of $self's value (see verification below) -- its removal from the variable.undefined baseline is an incidental consequence, not a fix to a real bug.

Verification

Since this is top-level script code (not a function) gated behind capability checks and wp_die(), it isn't practically unit-testable without fully bootstrapping an admin page render. Instead, since $parent_file is a fixed constant here, the whole expression reduces to a function of just $self and $item[2]. I exhaustively compared the old and new expressions across representative values of both, including $self's real runtime value ('themes.php') and the values Intelephense/PHPStan would assume if genuinely unset -- all agree:

self=NULL            item2='themes.php'    old=true  new=true  match
self=NULL            item2='nav-menus.php' old=false new=false match
self=NULL            item2=''              old=false new=false match
self=NULL            item2='0'             old=false new=false match
self='themes.php'    item2='themes.php'    old=true  new=true  match
... (16/16 combinations match)

Also ran the full admin test group (1910 tests) with no regressions.

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): The original commits (2a0ba8b and 25c18e3) do not record a model; Claude Opus 5.5 (medium and high effort) for the follow-up commits.
Used for: The original commits were authored with Claude Code. The follow-up commits, which restore the original condition and declare the globals, were written with Claude Code, along with a code review of the branch and this description; the changes were reviewed and directed by a human contributor.

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bgturner, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.