Repository navigation
Conversation
…sses. See #66549.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for code of the Abilities API classes that no test runs, according to the Codecov report.
WP_Ability_doing_it_wrong()and ignored.categoryis required (missing, empty,null, integer and array).ability_missing_input_schemawhen the ability has no input schema.wp_ability_validate_inputandwp_ability_validate_outputfilters can reject withfalse(Invalid input./Invalid output.).ability_invalid_execute_callback.WP_Erroris reported with_doing_it_wrong()and its reason is not shown to the caller.Registries and category
WP_Abilities_RegistryandWP_Ability_Categories_Registrycannot be serialized or unserialized.WP_Ability_Categories_Registry::get_instance()returnsnullbeforeinit, and creates the registry once and fireswp_abilities_api_categories_init.WP_Ability_Categorythrows for an empty slug.Testing
Mutation check: 24 changes to the source (conditions, error codes and messages, the
throwof__sleep()and__wakeup(), theinitcheck, the action and the instance creation) were each caught by a test.Trac ticket: https://core.trac.wordpress.org/ticket/66549
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Written with AI and manually reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.