Skip to content

Tests: Add unit tests for the uncovered code of the users ability - #15711

Closed
hmbashar wants to merge 1 commit into
WordPress:trunkfrom
hmbashar:66549-users-ability-tests
Closed

hmbashar wants to merge 1 commit into
WordPress:trunkfrom
hmbashar:66549-users-ability-tests

Conversation

@hmbashar

@hmbashar hmbashar commented Nov 6, 2026

Copy link
Copy Markdown

Summary

Adds tests for code of the core/users-query ability that no test runs, according to the Codecov report.

  • The description, url, first_name, last_name, nickname and locale fields are returned with their values to a caller who can edit the user, and only description and url are returned to a caller who cannot.
  • The execute callback honors an ID sent as a digit string, a float, a decimal string or a signed string, and rejects a fraction, a number below 1, a float beyond 2 ** 53, a negative digit string and a word.
  • A row that is not a user is skipped when a query filter changes the fields of the query.
  • A registration date that cannot be parsed is reported as null.

Testing

vendor/bin/phpunit --filter 'Tests_Abilities_API_WpRegisterCoreUsersAbility::'
vendor/bin/phpunit -c tests/phpunit/multisite.xml --filter 'Tests_Abilities_API_WpRegisterCoreUsersAbility::'
vendor/bin/phpcs tests/phpunit/tests/abilities-api/wpRegisterCoreUsersAbility.php

Mutation check: 12 changes to class-wp-abilities-users.php (each field, the integer parsing, the skip of rows that are not users and the date check) were each caught by a test.

Trac ticket: https://core.trac.wordpress.org/ticket/66549

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Written with AI and manually reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hmbashar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@hmbashar hmbashar closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant