Repository navigation
Conversation
hmbashar
marked this pull request as ready for review
November 6, 2026 14:04
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for
Plugin_Upgrader_Skin, which had no coverage (0% on Codecov).after()activates an active plugin again in a frame, but not an inactive plugin, a failed update or an update without an installed plugin.after()links to activate the plugin and to the Plugins page, and leaves out the link to activate it after a failure or for a user who cannot activate plugins.update_plugin_complete_actionsfilter receives the links and the plugin file, and no feedback is given when the links are removed.Testing
Mutation check: 18 changes to
class-plugin-upgrader-skin.php(the conditions of the frame and of the links, the filter, the separator, the nonce, the update count) were each caught by a test. The change to the network active check is caught by the multisite run only.The skin collects its feedback in the test, because
show_message()ends all output buffers.Trac ticket: https://core.trac.wordpress.org/ticket/66551
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Written with AI and manually reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.