Repository navigation
Build/Test Tools: Wait for menu saves in the classic menus E2E test. - #15772
Closed
lancewillett wants to merge 1 commit into
Closed
lancewillett wants to merge 1 commit into
lancewillett wants to merge 1 commit into
Conversation
The "creates a menu" test moved on before each save had finished loading, in two places: 1. After Create Menu, it checked that the Menu Name field showed "E2E Menu". The test had typed that value itself, so the check could pass on the create form before the page reloaded. The next step then clicked Custom Links on the create form, where the side panels are disabled, and timed out waiting for the URL field. 2. After Save Menu, it polled REST for the saved location. The server can save before the browser finishes loading the response, so the next `page.goto( '/' )` was interrupted by that navigation. The test now waits for the redirect to the new menu's edit screen, and for the "has been updated" notice after saving. See #66455. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
adimoldovan
approved these changes
Nov 9, 2026
wporg-sync
pushed a commit
that referenced
this pull request
Nov 9, 2026
Developed in: #15772 Props adrianmoldovanwp. See #66455. git-svn-id: https://develop.svn.wordpress.org/trunk@65348 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
|
PR #15772 landed in https://core.trac.wordpress.org/changeset/65348 |
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Nov 9, 2026
Developed in: WordPress/wordpress-develop#15772 Props adrianmoldovanwp. See #66455. Built from https://develop.svn.wordpress.org/trunk@65348 git-svn-id: http://core.svn.wordpress.org/trunk@64488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classic menus "creates a menu, adds a custom link, and assigns it to a location" test passed only on retry in 7 of the 216 parallel E2E jobs that finished on November 6. It moved on before each save had finished loading, in two places.
What
?action=edit&menu=0, side panels disabled) and timed out waiting for the URL field. The test now waits for the redirect to?menu=<id>first.page.goto( '/' )failed with "interrupted by another navigation". The test now waits for the "E2E Menu has been updated." notice, which only the saved page shows.Evidence
First-attempt errors from the retried jobs:
locator.fill: Timeout 10000ms exceeded, waiting forgetByRole('textbox', { name: 'URL' }): runs 42146221073, 42215459048, 42218822487, 42256787659, 42277031851.page.goto: Navigation to "http://localhost:8889/" is interrupted by another navigation: runs 42162810740, 42193906832.No local reproduction; the cause is inferred from the errors and the
nav-menus.phpredirects.Trac ticket: https://core.trac.wordpress.org/ticket/66455
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Scanning CI logs, finding the cause, writing the change and this description.
🤖 Generated with Claude Code