Repository navigation
KSES: Remove NOSCRIPT elements without discarding the content that follows them - #15927
SainathPoojary wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Since the HTML API rewrite of KSES,
wp_kses()stops at the first<noscript>and drops everything after it. For users withoutunfiltered_html(Authors, Contributors, commenters), the rest of the post or comment is lost on save.This PR removes the
<noscript>element and its contents, and keeps the content after it.How:
<noscript>, count open<noscript>tags and skip every token until the matching closing tag.<noscript>is counted. Inside SVG or MathML, the allow-list already handles it.Before:
Screen.Recording.2026-11-12.at.6.36.05.PM.mov
After:
Screen.Recording.2026-11-12.at.6.35.15.PM.mov
Trac ticket: https://core.trac.wordpress.org/ticket/66674
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the initial draft and tests. I reviewed and tested the changes locally.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.