Skip to content

KSES: Remove NOSCRIPT elements without discarding the content that follows them - #15927

Open
SainathPoojary wants to merge 2 commits into
WordPress:trunkfrom
SainathPoojary:fix/66674-kses-noscript
Open

SainathPoojary wants to merge 2 commits into
WordPress:trunkfrom
SainathPoojary:fix/66674-kses-noscript

Conversation

@SainathPoojary

@SainathPoojary SainathPoojary commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Since the HTML API rewrite of KSES, wp_kses() stops at the first <noscript> and drops everything after it. For users without unfiltered_html (Authors, Contributors, commenters), the rest of the post or comment is lost on save.

This PR removes the <noscript> element and its contents, and keeps the content after it.

How:

  • Instead of stopping at <noscript>, count open <noscript> tags and skip every token until the matching closing tag.
  • Nothing inside is output, so the original safety goal still holds.
  • Only HTML <noscript> is counted. Inside SVG or MathML, the allow-list already handles it.

Before:

Screen.Recording.2026-11-12.at.6.36.05.PM.mov

After:

Screen.Recording.2026-11-12.at.6.35.15.PM.mov

Trac ticket: https://core.trac.wordpress.org/ticket/66674

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the initial draft and tests. I reviewed and tested the changes locally.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@SainathPoojary
SainathPoojary marked this pull request as ready for review November 12, 2026 16:22
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant