Skip to content

Add PHPUnit tests for wp_widgets_add_menu function - #5830

Closed
pbearne wants to merge 6 commits into
WordPress:trunkfrom
pbearne:60179-wp_widgets_add_menu
Closed

pbearne wants to merge 6 commits into
WordPress:trunkfrom
pbearne:60179-wp_widgets_add_menu

Conversation

@pbearne

@pbearne pbearne commented Jan 2, 2024

Copy link
Copy Markdown

This commit introduces PHPUnit tests for the wp_widgets_add_menu function. The tests are implemented in a new file, wpWidgetsAddMenu.php, inside the tests/phpunit/tests/functions/ directory and cover different cases and scenarios to ensure proper functionality of the wp_widgets_add_menu function.

Trac ticket: https://core.trac.wordpress.org/ticket/60179

This commit introduces PHPUnit tests for the wp_widgets_add_menu function. The tests are implemented in a new file, wpWidgetsAddMenu.php, inside the tests/phpunit/tests/functions/ directory and cover different cases and scenarios to ensure proper functionality of the wp_widgets_add_menu function.
@github-actions

github-actions Bot commented Jan 2, 2024

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions

github-actions Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The tests use assertEqualSets(), which discards the themes.php key and allows an incorrect Widgets parent menu to pass; both tests need assertSame() to verify the complete submenu structure.

1 open issue
What changed in this PR

Adds PHPUnit coverage for wp_widgets_add_menu(), which registers the Widgets submenu in WordPress administration.

Changes:

  • Tests submenu registration for default and block themes.
  • Tests that no submenu is added when widget support is disabled.
  • Saves and restores the global submenu state around each test.
File Description
tests/​phpunit/​tests/​wp-includes/​functions/​WpWidgetsAddMenuTest.php Adds three widget-menu tests with submenu setup and cleanup.

Review effort: Balanced

wp_widgets_add_menu();

$expected['themes.php'][8] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' );
$this->assertEqualSets( $expected, $submenu );

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied to current trunk, the randomized local run fails test_wp_widgets_add_menu: expected submenu index 8, actual 9. Please refresh the contract and explicitly arrange the intended theme/menu state. This overlaps #3699, so consolidate the alternatives rather than landing both. The sampled CI failure was a build timeout, but this local failure is a separate stale test expectation.

AI review · gpt-6

@pbearne

pbearne commented Nov 9, 2026

Copy link
Copy Markdown
Author

closed as dupicate #3699

@pbearne pbearne closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants