From 080bca262c22c99a2e656c673a41d476fadfd284 Mon Sep 17 00:00:00 2001 From: Paul Bearne Date: Tue, 2 Jan 2024 18:39:23 -0500 Subject: [PATCH 1/3] Add PHPUnit tests for wp_widgets_add_menu function This commit introduces PHPUnit tests for the wp_widgets_add_menu function. The tests are implemented in a new file, wpWidgetsAddMenu.php, inside the tests/phpunit/tests/functions/ directory and cover different cases and scenarios to ensure proper functionality of the wp_widgets_add_menu function. --- .../tests/functions/wpWidgetsAddMenu.php | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 tests/phpunit/tests/functions/wpWidgetsAddMenu.php diff --git a/tests/phpunit/tests/functions/wpWidgetsAddMenu.php b/tests/phpunit/tests/functions/wpWidgetsAddMenu.php new file mode 100644 index 0000000000000..965c2e063e26f --- /dev/null +++ b/tests/phpunit/tests/functions/wpWidgetsAddMenu.php @@ -0,0 +1,68 @@ +submenu = $submenu; + $submenu = null; + } + + public function tear_down() { + global $submenu; + $submenu = $this->submenu; + } + + /** + * @ticket 60179 + */ + public function test_wp_widgets_add_menu() { + global $submenu; + wp_widgets_add_menu(); + + $expected['themes.php'][7] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); + $this->assertEqualSets( $expected, $submenu ); + } + + /** + * @ticket 60179 + */ + public function test_wp_widgets_add_menu_no_widget_support() { + global $submenu; + + add_filter( 'current_theme_supports-widgets', '__return_false' ); + + wp_widgets_add_menu(); + + remove_filter( 'current_theme_supports-widgets', '__return_false' ); + + $this->assertNull( $submenu ); + } + + /** + * @ticket 60179 + */ + public function test_wp_widgets_add_menu_block_template_parts_supported() { + global $submenu, $_wp_theme_features; + + $_wp_theme_features['block-template-parts'] = true; + add_filter( 'current_theme_supports-block-template-parts', '__return_true' ); + + wp_widgets_add_menu(); + + unset( $_wp_theme_features['block-template-parts'] ); + remove_filter( 'current_theme_supports-block-template-parts', '__return_true' ); + + $expected['themes.php'][] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); + $this->assertEqualSets( $expected, $submenu ); + } +} From ef453e784fc387118397cf981e7313f94c1fd76f Mon Sep 17 00:00:00 2001 From: Paul Bearne Date: Wed, 3 Jan 2024 12:22:47 -0500 Subject: [PATCH 2/3] Update tests/phpunit/tests/functions/wpWidgetsAddMenu.php Co-authored-by: Mukesh Panchal --- tests/phpunit/tests/functions/wpWidgetsAddMenu.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/tests/functions/wpWidgetsAddMenu.php b/tests/phpunit/tests/functions/wpWidgetsAddMenu.php index 965c2e063e26f..993670cebe283 100644 --- a/tests/phpunit/tests/functions/wpWidgetsAddMenu.php +++ b/tests/phpunit/tests/functions/wpWidgetsAddMenu.php @@ -3,7 +3,7 @@ /** * Tests for the wp_widgets_add_menu function. * - * @group Functions + * @group functions * * @covers ::wp_widgets_add_menu */ From 81af24fab8ae022c1bf87d20891d72739036925f Mon Sep 17 00:00:00 2001 From: Paul Bearne Date: Fri, 18 Sep 2026 13:28:46 -0400 Subject: [PATCH 3/3] Refactor `wp_widgets_add_menu` tests: update class name, namespace, and method contents. --- .../functions/WpWidgetsAddMenuTest.php} | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) rename tests/phpunit/tests/{functions/wpWidgetsAddMenu.php => wp-includes/functions/WpWidgetsAddMenuTest.php} (64%) diff --git a/tests/phpunit/tests/functions/wpWidgetsAddMenu.php b/tests/phpunit/tests/wp-includes/functions/WpWidgetsAddMenuTest.php similarity index 64% rename from tests/phpunit/tests/functions/wpWidgetsAddMenu.php rename to tests/phpunit/tests/wp-includes/functions/WpWidgetsAddMenuTest.php index 993670cebe283..dc320b946c2e6 100644 --- a/tests/phpunit/tests/functions/wpWidgetsAddMenu.php +++ b/tests/phpunit/tests/wp-includes/functions/WpWidgetsAddMenuTest.php @@ -1,17 +1,22 @@ submenu = $submenu; $submenu = null; @@ -20,6 +25,7 @@ public function set_up() { public function tear_down() { global $submenu; $submenu = $this->submenu; + parent::tear_down(); } /** @@ -29,7 +35,7 @@ public function test_wp_widgets_add_menu() { global $submenu; wp_widgets_add_menu(); - $expected['themes.php'][7] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); + $expected['themes.php'][8] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); $this->assertEqualSets( $expected, $submenu ); } @@ -51,17 +57,13 @@ public function test_wp_widgets_add_menu_no_widget_support() { /** * @ticket 60179 */ - public function test_wp_widgets_add_menu_block_template_parts_supported() { - global $submenu, $_wp_theme_features; + public function test_wp_widgets_add_menu_block_theme() { + global $submenu; - $_wp_theme_features['block-template-parts'] = true; - add_filter( 'current_theme_supports-block-template-parts', '__return_true' ); + switch_theme( 'block-theme' ); wp_widgets_add_menu(); - unset( $_wp_theme_features['block-template-parts'] ); - remove_filter( 'current_theme_supports-block-template-parts', '__return_true' ); - $expected['themes.php'][] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); $this->assertEqualSets( $expected, $submenu ); }