Repository navigation
Conversation
A new unit test for the wp_staticize_emoji_for_email function has been added. This test provides verification for a variety of scenarios; from simple messages, messages with emojis, and adjustments based on the email's content type.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Two new unit tests have been added for the wp_enqueue_emoji_styles function. Both tests provide different scenarios - one checks if the expected styles are included in wp_print_styles, and the other tests the non-inclusion after the print_emoji_styles action has been removed.
This reverts commit f33ce9f.
…pt' into 60301-print_emoji_detection_script
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
🟡 Changes recommended
The emoji detection test can fail when embed-template tests run first because a persistent function-local static flag suppresses output and cannot be reset by teardown.
1 open issue
What changed in this PR
This PR adds formatting test coverage for print_emoji_detection_script(), rather than the email emoji function named in the PR description.
Changes:
- Verify that the script output contains the expected emoji CDN URL.
- Verify that a second invocation produces no output.
| File | Description |
|---|---|
| tests/phpunit/tests/formatting/printEmojiDetectionScript.php | Adds checks for emoji detection-script output and one-time printing. |
Review effort: Balanced
| class Tests_formatting_printEmojiDetectionScript extends WP_UnitTestCase { | ||
|
|
||
| /** | ||
| * @ticket 60301 |
|
Closing as superseded by trunk’s CDN output checks and one-time printing checks. These cover both assertions here using current emoji URLs and the required process isolation. Thank you for the proposed coverage. AI review · |

A new unit test for the wp_staticize_emoji_for_email function has been added. This test provides verification for a variety of scenarios; from simple messages, messages with emojis, and adjustments based on the email's content type.
Trac ticket: https://core.trac.wordpress.org/ticket/60300