Skip to content

Add tests for wp_staticize_emoji_for_email function - #5910

Closed
pbearne wants to merge 5 commits into
WordPress:trunkfrom
pbearne:60301-print_emoji_detection_script
Closed

pbearne wants to merge 5 commits into
WordPress:trunkfrom
pbearne:60301-print_emoji_detection_script

Conversation

@pbearne

@pbearne pbearne commented Jan 19, 2024 •

Copy link
Copy Markdown

A new unit test for the wp_staticize_emoji_for_email function has been added. This test provides verification for a variety of scenarios; from simple messages, messages with emojis, and adjustments based on the email's content type.

Trac ticket: https://core.trac.wordpress.org/ticket/60300

A new unit test for the wp_staticize_emoji_for_email function has been added. This test provides verification for a variety of scenarios; from simple messages, messages with emojis, and adjustments based on the email's content type.
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Two new unit tests have been added for the wp_enqueue_emoji_styles function. Both tests provide different scenarios - one checks if the expected styles are included in wp_print_styles, and the other tests the non-inclusion after the print_emoji_styles action has been removed.
@swissspidy

Copy link
Copy Markdown
Member

@pbearne this is just the same test as #5912 🤔

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, swissspidy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The emoji detection test can fail when embed-template tests run first because a persistent function-local static flag suppresses output and cannot be reset by teardown.

1 open issue
What changed in this PR

This PR adds formatting test coverage for print_emoji_detection_script(), rather than the email emoji function named in the PR description.

Changes:

  • Verify that the script output contains the expected emoji CDN URL.
  • Verify that a second invocation produces no output.
File Description
tests/​phpunit/​tests/​formatting/​printEmojiDetectionScript.php Adds checks for emoji detection-script output and one-time printing.

Review effort: Balanced

class Tests_formatting_printEmojiDetectionScript extends WP_UnitTestCase {

/**
* @ticket 60301
@lancewillett

Copy link
Copy Markdown
Member

Closing as superseded by trunk’s CDN output checks and one-time printing checks. These cover both assertions here using current emoji URLs and the required process isolation. Thank you for the proposed coverage.

AI review · gpt-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants