Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Refreshed in a496b67. Two independent cases now cover activation from the theme card and confirmed deletion from theme details. A local fixture replaces the live theme-directory dependency. Both cases verify visible results and persisted state after reload. Cleanup restores the previous theme and removes only the fixture. Six local checks passed without retries (33.5 seconds); scoped E2E and five-steps audits found no blockers. CI and independent review are next. Fixture packaging is still under discussion alongside #8075: committed ZIPs versus archives generated in memory. AI review · |
|
Review of a496b67. No requested changes. What I checked
CIRun 38282514842 is green. Both new cases passed on the first attempt in both E2E jobs. One existing test was retried in each job: AI review · |
lucatume
left a comment
There was a problem hiding this comment.
A suggestion to improve the clean-up.
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues remain in the test flows, cleanup safeguards, or fixture documentation.
No open issues 🎉
What changed in this PR
Adds browser coverage for single-site theme activation and deletion, using a local fixture instead of a live theme download.
Changes:
- Adds independent activation and deletion tests with reload and REST verification.
- Restores the original active theme and removes only the test fixture during cleanup.
- Documents the fixture contents and byte-for-byte archive regeneration.
| File | Description |
|---|---|
tests/e2e/specs/themes.test.js |
Adds theme-management tests with guarded setup and cleanup. |
tests/e2e/assets/e2e-test-theme.md |
Documents the minimal theme fixture and its regeneration script. |
Review effort: Balanced
lancewillett
left a comment
There was a problem hiding this comment.
The cleanup is independent of the details overlay, and the local fixture regenerates byte-for-byte. Both cases passed three times in each SCRIPT_DEBUG mode (12 checks). Optional later improvement: install the fixture outside the browser to reduce repeated setup work.
Reviewed with the PR-scoped E2E and five-steps audits. No blockers found; local runs used one worker and zero retries. Current CI and Copilot review are clear.
AI review · gpt-6
Add browser tests for activating and deleting a theme using a local ZIP fixture. Restore the original active theme and remove the fixture after each test. Developed in: #8082 Props juhise, lucatume. See #52895. git-svn-id: https://develop.svn.wordpress.org/trunk@64736 602fd350-edb4-49c9-b593-d223f7449a82
|
PR #8082 landed in https://core.trac.wordpress.org/changeset/64736 |
Add browser tests for activating and deleting a theme using a local ZIP fixture. Restore the original active theme and remove the fixture after each test. Developed in: WordPress/wordpress-develop#8082 Props juhise, lucatume. See #52895. Built from https://develop.svn.wordpress.org/trunk@64736 git-svn-id: http://core.svn.wordpress.org/trunk@63886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add `themes.test.js` and the fixture documentation from the reviewed patch. [64736] added the ZIP fixture but omitted these two files. Developed in: #8082 Props juhise, lucatume. See #52895. git-svn-id: https://develop.svn.wordpress.org/trunk@64739 602fd350-edb4-49c9-b593-d223f7449a82
Add `themes.test.js` and the fixture documentation from the reviewed patch. [64736] added the ZIP fixture but omitted these two files. Developed in: WordPress/wordpress-develop#8082 Props juhise, lucatume. See #52895. Built from https://develop.svn.wordpress.org/trunk@64739 git-svn-id: http://core.svn.wordpress.org/trunk@63889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Adds two independent browser checks for theme management:
A tiny local ZIP fixture replaces the live Hello Elementor download. Setup uploads it separately for each case. Cleanup restores the previous active theme and removes only the fixture using its signed deletion URL, with REST checks afterward.
A preexisting fixture makes setup fail without deleting it. The fixed fixture slug assumes an environment not shared with another simultaneous test run, matching current CI. These cases cover single-site theme management; installation from the remote theme directory is outside this scope.
Trac ticket: https://core.trac.wordpress.org/ticket/52895
Verification
Fixtures
The archives are committed, not built at test time. Trunk already keeps ZIP fixtures for tests, including a plugin archive for install tests at
tests/phpunit/data/plugins/link-manager.zip. Building them in the spec would need a ZIP library that core does not declare. The note beside each archive lists its full contents and a script that rebuilds it byte for byte.Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-6
Used for: Refreshing the tests, replacing the live theme dependency with a local fixture, and local validation and audits.