Skip to content

Update: Use sass instead of node-sass in twentynineteen theme - #8405

Closed
Debarghya-Banerjee wants to merge 2 commits into
WordPress:trunkfrom
Debarghya-Banerjee:update/npm-packages-of-twenty-nineteen-theme
Closed

Debarghya-Banerjee wants to merge 2 commits into
WordPress:trunkfrom
Debarghya-Banerjee:update/npm-packages-of-twenty-nineteen-theme

Conversation

@Debarghya-Banerjee

Copy link
Copy Markdown

Trac Ticket: Core-63013

Summary

This PR replaces node-sass with sass in the twentynineteen theme. node-sass is deprecated and no longer maintained, while sass is the official, actively supported implementation of Sass.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano

t-hamano commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Closing in favor of #12510. Thank you for your work on this!

@t-hamano t-hamano closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants