Skip to content

init_app should not reference self. #50

Description

@nickelwound

This line appears to break the following common pattern:

def create_app():
    """Bootstrap the app. Takes an instance of the Flask obj/app."""
    app = Flask(__name__)
    request_id = RequestID()
    request_id.init_app(app)
    return app

traceback:

    request_id.init_app(app)
  File "/usr/local/lib/python3.7/site-packages/flask_log_request_id/request_id.py", line 84, in init_app
    if self.app.config['LOG_REQUEST_ID_LOG_ALL_REQUESTS']:
AttributeError: 'NoneType' object has no attribute 'config'

When init_app is called, self.app has not been assigned. It should use the passed app object.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions