fix(prefix,shortcuts,setup): skip installed winetricks verbs; install-shortcut all --reinstall

prefix.sh: pre-fetch 'winetricks list-installed' once before the fast verb loop. Verbs already present are printed as 'already installed' and skipped with no winetricks invocation. Only missing verbs go through the install+retry path. Saves the full re-install time on wig init / wig quick when the prefix is already set up.

shortcuts.sh: create_all_shortcuts() accepts an optional --reinstall flag. Without it (current behaviour) only launchers with a detectable exe get shortcuts. With --reinstall, shortcuts are created for all APP_REGISTRY entries regardless of install status — useful for updating the .desktop template (e.g. after the StartupNotify fix) on a fresh or mid-setup prefix.

setup: install-shortcut all --reinstall now routes through create_all_shortcuts --reinstall.

Author: xaoscience

lib/prefix.sh

@@ -45,9 +45,17 @@ _install_winetricks_verbs() {
             export LD_LIBRARY_PATH="$PROTON_DIR/files/lib:$PROTON_DIR/files/lib64${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
 
         print_info "Installing fast winetricks verbs (${#fast_verbs[@]} packages)..."
+        # Pre-fetch installed verbs once; avoids reinstalling on quick/init runs.
+        local _installed_verbs
+        _installed_verbs=$(WINETRICKS_LATEST_VERSION_CHECK=disabled winetricks list-installed 2>/dev/null || true)
+
         local v _ok
         for v in "${fast_verbs[@]}"; do
             printf "  → %s ... " "$v"
+            if echo "$_installed_verbs" | grep -qx "$v" 2>/dev/null; then
+                echo "already installed"
+                continue
+            fi
             _ok=0
             for _try in 1 2; do
                 WINETRICKS_LATEST_VERSION_CHECK=disabled \

lib/shortcuts.sh

@@ -237,10 +237,15 @@ remove_shortcut() {
 # Recreate shortcuts for every installed launcher.
 # Skips apps not currently present in the prefix.
 create_all_shortcuts() {
-    print_info "Recreating shortcuts for all installed launchers..."
+    local _force="${1:-}"
+    if [ "$_force" = "--reinstall" ]; then
+        print_info "Recreating shortcuts for all registered launchers (--reinstall: ignoring install status)..."
+    else
+        print_info "Recreating shortcuts for all installed launchers..."
+    fi
     local created=0 skipped=0
     for app_key in "${!APP_REGISTRY[@]}"; do
-        if find_app_exe "$app_key" >/dev/null 2>&1; then
+        if [ "$_force" = "--reinstall" ] || find_app_exe "$app_key" >/dev/null 2>&1; then
             create_shortcut "$app_key" && ((created++)) || true
         else
             ((skipped++))

setup

@@ -176,7 +176,7 @@ main() {
         install-shortcut)
             shift
             if [ "$1" = "all" ]; then
-                create_all_shortcuts
+                create_all_shortcuts "${2:-}"
             elif [[ "$1" == /* || "$1" == ./* || "${1,,}" == *.exe || "${1,,}" == *.lnk ]]; then
                 create_external_shortcut "$@"
             else