Skip to content

chore: upgrade Osano CMP to new account - #3412

Open
dangell7 wants to merge 3 commits into
mainfrom
osano-cmp-upgrade
Open

dangell7 wants to merge 3 commits into
mainfrom
osano-cmp-upgrade

Conversation

@dangell7

@dangell7 dangell7 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Replaces the Osano cookie-consent script on js.xrpl.org with the new XRPLF account key (SXt7r81ogd/410d1eb2-0ebf-40b5-9444-bee536d25b61), part of the Osano rollout across the four xrpl.org domains.

One-line change in packages/xrpl/typedoc.mts — the docs HTML is regenerated by CI (generate-documentation.yml) and deployed to GitHub Pages during the release workflow, so no generated files are included. js.xrpl.org will pick up the new script on the next non-beta release.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7633b556-83cc-4e4a-b7ea-9ca80bca027d

📥 Commits

Reviewing files that changed from the base of the PR and between 67b29c0 and 5d0232f.

📒 Files selected for processing (1)
  • packages/xrpl/typedoc.mts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/xrpl/typedoc.mts

Walkthrough

The documentation loader’s Osano script URL was changed to a new osano.js endpoint. The surrounding load logic and HTML structure remain unchanged.

Changes

Documentation script loading

Layer / File(s) Summary
Update Osano script endpoint
packages/xrpl/typedoc.mts
The first inserted script tag now references the revised Osano URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny hopped through docs so bright,
And swapped one script URL just right.
The loader stayed upon its track,
With Osano’s new path in its pack.
“One tiny change!” cheered the rabbit.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning It covers the change and context, but it omits required template sections for Type of Change, HISTORY.md, and Test Plan. Add the missing template headings and fill in the type selection, HISTORY.md update status, and a reproducible test plan.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating the Osano CMP account key.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch osano-cmp-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread packages/xrpl/typedoc.mts
@kuan121
kuan121 force-pushed the osano-cmp-upgrade branch from 67b29c0 to 5d0232f Compare July 28, 2026 15:12
@kuan121

kuan121 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Merging is blocked
Commits must have verified signatures.

@dangell7 You need to sign your commits.

@kuan121

kuan121 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Merging is blocked
Commits must have verified signatures.

@dangell7 The PR is still merge block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants