fix(runner): propagate pytest exit status - #196
Open
FU-max-boop wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest.main()throughmain()to the shellprocess_doc_result()after pytest so reports are still finalized for ordinary pytest failuresmain -> SystemExitfailure pathProblem
run.pycalledpytest.main(...)but discarded its return value, then invokedmain()withoutSystemExit. A failed, interrupted, invalid, or empty test run could therefore complete with shell status 0 and make Make/CI report a false success.Baseline reproduced in the project container:
Result
The second path still invokes report post-processing before returning 5.
Validation
python3 -m pytest -q -p no:toffee-test testsSystemExit(1)python3 -m py_compile run.py tests/test_run.pygit diff --checkThe unit tests replace only the
commdependency tree, so they require no DUT build, RTL download, or current project Python dependencies.Compatibility boundary
This change only propagates pytest return codes. Existing early-return behavior for configuration errors,
--download-rtl, and--build, plus existingbuild_dutfailure handling, is unchanged.