fix(replay): drive payloads and pulse event inputs - #197
Open
FU-max-boop wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Replay agent had two event-driving problems:
replay()assignedsourceIdandisKeywordto the bound attributes insteadof driving the pins through
.value, so the L2-hint payload did not reach theDUT.
replay()andUpdate_blocking()left eventvalidinputs asserted afterreturning. A later request could therefore observe an event that belonged to
an earlier driver call. On the generated DUT, a stale TL refill for MSHR 8
incorrectly cleared
blockingfor a later MSHR-8 entry.This change:
and TL refill
validinputs for one cycle;replay: 4 cycles;Update_blocking: 2 cycles) and retains the persistent non-event inputsaccepted by
Update_blocking();initializing its Replay inputs to idle values, asserting reset before
toffee.start_clock(dut), and waiting one post-reset idle cycle before thefirst enqueue;
lqFullas the DUT output declared by the RTL instead of driving itfrom the fixture's idle-input helper.
The current branch head is
1b314cad2d7918c4ae21bec1892ed92202389d97. Its third and fourth commits aretest-only; the production event-pulse change remains
e73dbac.Tests
The new agent regressions were overlaid on the exact pre-event-pulse commit and
then run at current head
1b314ca(whose production agent is unchanged frome73dbac):Using the same generated
LoadQueueReplayDUT for both controls:py_compile,git diff --check, and the selected ARM64 generated-DUT testspass at current head
1b314ca. In the official x86 image (Python 3.10.12,Verilator 5.030, public Picker
c100874), both agent tests and both selectedgenerated-DUT tests also pass; the generated-DUT run completed in 591.31 s
with no RTL assertions.
The completed ARM64 generated-DUT run used Python 3.12.3, Verilator 5.020, RTL
archive
openxiangshan-kmh-66e9b546-25022801, and Picker commit6981bc5. ThatPicker commit is an unpublished validation-tool workaround supplying a
Verilator-5.020 DPI lookup compatibility fallback needed to construct this
model; it is not a dependency of the Replay-agent source change.
Scope
The ARM64 and official x86 generated-DUT regressions prove stale TL-refill
isolation and fresh-event recovery for one held entry. The other event pulses
and the persistent non-event inputs accepted by
Update_blocking()are coveredat the agent boundary. This PR does not claim the full Replay cause matrix,
multi-entry arbitration, or exact scheduling-latency coverage.
Related #133; follow-up to #143 and #157. This PR does not claim to close or
complete #133.