Addon: [1.9.13] Fix FocusTarget bits stale on Vanilla/SoM - TargetFocusTargetGoal never runs

The event-driven BitCache introduced in PR #742 broke the Assist Focus
workflow on Vanilla Classic / Season of Mastery. The GOAP planner would
pick "Follow Focus" (cost 19) instead of "Target Focus Target" (cost 10)
because TargetFocusTargetGoal.CanRun() always evaluated to false.

Root cause: UNIT_FLAGS does not fire for derived/compound unit tokens
like "focustarget" or "party1target". So focusTargetInCombat (bit 6) was
only set when UpdateFocusCache() ran on UNIT_TARGET (target change). If
the mob entered combat after being targeted, the combat flag stayed
false forever until the focus changed target.

Additionally, on Vanilla Classic the "focus" unit token doesn't exist -
the addon maps it to "party1" via DataToColor.C.unitFocus. The
OnUnitTarget_BitCache and OnUnitFlags_BitCache handlers only checked for
the literal "focus" string, missing "party1" entirely.

Finally, PLAYER_FOCUS_CHANGED may not exist on Vanilla Classic, and
using RegisterEvent instead of SafeRegisterEvent could abort subsequent
event registrations in the same block if it errors.

Changes:

BitCache.lua:
- Poll focusTargetInCombat every frame in UpdatePolledValues() since
  UNIT_FLAGS never fires for derived unit tokens - this is 1 cheap
  UnitAffectingCombat() call per frame, only when focusTargetExists

EventHandlers.lua:
- Add DataToColor.C.unitFocus checks alongside literal "focus" in
  OnUnitTarget_BitCache and OnUnitFlags_BitCache so Vanilla "party1"
  token is handled correctly
- Same for DataToColor.C.unitFocusTarget alongside "focustarget"
- Use SafeRegisterEvent for PLAYER_FOCUS_CHANGED to prevent errors on
  Vanilla Classic from aborting subsequent event registrations
- Register GROUP_ROSTER_UPDATE event with new OnGroupRosterUpdate_BitCache
  handler to refresh focus cache when party composition changes

ClassConfiguration.cs:
- On SoM/Vanilla, override TargetFocus.BindingID from TARGETFOCUS to
  TARGETPARTYMEMBER1 since Vanilla has no /targetfocus keybind

Addon version bumped 1.9.12 -> 1.9.13

Fixes #788

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Xian55

Addons/DataToColor/BitCache.lua

@@ -387,6 +387,12 @@ local function UpdatePolledValues()
     bits3Cache.chatInputActive = DataToColor:IsChatInputActive() or false
     UpdateMailFrameCache()
 
+    -- Focus target combat state - UNIT_FLAGS doesn't fire for derived units
+    -- like "focustarget" / "party1target", so we must poll
+    if bits2Cache.focusTargetExists then
+        bits2Cache.focusTargetInCombat = UnitAffectingCombat(DataToColor.C.unitFocusTarget) or false
+    end
+
     -- Spell states - must be polled because bot checks these immediately after
     -- sending key presses, faster than START/STOP_AUTOREPEAT_SPELL events fire
     UpdateSpellStateCache()

Addons/DataToColor/DataToColor.toc

@@ -2,7 +2,7 @@
 ## Title: DataToColor
 ## Author: FreeHongKongMMO
 ## Notes: Displays data as colors (Legacy Cataclysm 4.3.0)
-## Version: 1.9.12
+## Version: 1.9.13
 ## RequiredDeps:
 ## OptionalDeps: Ace3, LibRangeCheck, cTimerBackport
 ## SavedVariables:

Addons/DataToColor/DataToColor_Classic.toc

@@ -2,7 +2,7 @@
 ## Title: DataToColor
 ## Author: FreeHongKongMMO
 ## Notes: Displays data as colors (Classic)
-## Version: 1.9.12
+## Version: 1.9.13
 ## RequiredDeps:
 ## OptionalDeps: Ace3, LibRangeCheck, LibClassicCasterino
 ## SavedVariables:

Addons/DataToColor/DataToColor_TBC.toc

@@ -2,7 +2,7 @@
 ## Title: DataToColor
 ## Author: FreeHongKongMMO
 ## Notes: Displays data as colors (Classic TBC)
-## Version: 1.9.12
+## Version: 1.9.13
 ## RequiredDeps:
 ## OptionalDeps: Ace3, LibRangeCheck, LibClassicCasterino
 ## SavedVariables:

Addons/DataToColor/EventHandlers.lua

@@ -159,9 +159,10 @@ function DataToColor:RegisterEvents()
     ---------------------------------------------------------------------------
     DataToColor:RegisterEvent('UNIT_TARGET', 'OnUnitTarget_BitCache')
     DataToColor:RegisterEvent('UPDATE_MOUSEOVER_UNIT', 'OnMouseoverChanged_BitCache')
-    DataToColor:RegisterEvent('PLAYER_FOCUS_CHANGED', 'OnFocusChanged_BitCache')
+    DataToColor:SafeRegisterEvent('PLAYER_FOCUS_CHANGED', 'OnFocusChanged_BitCache')
     DataToColor:RegisterEvent('PLAYER_REGEN_DISABLED', 'OnEnteredCombat')
     DataToColor:RegisterEvent('UNIT_FLAGS', 'OnUnitFlags_BitCache')
+    DataToColor:RegisterEvent('GROUP_ROSTER_UPDATE', 'OnGroupRosterUpdate_BitCache')
     DataToColor:RegisterEvent('PLAYER_DEAD', 'OnPlayerDead_BitCache')
     DataToColor:RegisterEvent('PLAYER_ALIVE', 'OnPlayerAlive_BitCache')
     DataToColor:RegisterEvent('PLAYER_UNGHOST', 'OnPlayerUnghost_BitCache')
@@ -937,7 +938,7 @@ function DataToColor:OnUnitTarget_BitCache(event, unit)
     if DataToColor.BitCache and DataToColor.BitCache.updateTargetTarget then
         if unit == "target" then
             DataToColor.BitCache.updateTargetTarget()
-        elseif unit == "focus" then
+        elseif unit == "focus" or unit == DataToColor.C.unitFocus then
             DataToColor.BitCache.updateFocus()
         elseif unit == "pet" then
             DataToColor.BitCache.updatePet()
@@ -974,13 +975,19 @@ function DataToColor:OnUnitFlags_BitCache(event, unit)
     if not DataToColor.BitCache or not DataToColor.BitCache.bits1 then return end
     if unit == "target" then
         DataToColor.BitCache.bits1.targetInCombat = UnitAffectingCombat(unit) or false
-    elseif unit == "focus" then
+    elseif unit == "focus" or unit == DataToColor.C.unitFocus then
         DataToColor.BitCache.bits2.focusInCombat = UnitAffectingCombat(unit) or false
-    elseif unit == "focustarget" then
+    elseif unit == "focustarget" or unit == DataToColor.C.unitFocusTarget then
         DataToColor.BitCache.bits2.focusTargetInCombat = UnitAffectingCombat(unit) or false
     end
 end
 
+function DataToColor:OnGroupRosterUpdate_BitCache(event)
+    if DataToColor.BitCache and DataToColor.BitCache.updateFocus then
+        DataToColor.BitCache.updateFocus()
+    end
+end
+
 function DataToColor:OnPlayerDead_BitCache(event)
     if DataToColor.BitCache and DataToColor.BitCache.bits1 then
         DataToColor.BitCache.bits1.playerIsDeadOrGhost = true

Core/ClassConfig/ClassConfiguration.cs

@@ -3,6 +3,8 @@
 
 using Newtonsoft.Json;
 
+using SharedLib;
+
 using System;
 using System.Collections.Frozen;
 using System.Collections.Generic;
@@ -213,6 +215,12 @@ public void Initialise(IServiceProvider sp, Dictionary<int, string> overridePath
 
         RequirementFactory factory = new(sp, this);
 
+        // Vanilla has no TARGETFOCUS binding — use TARGETPARTYMEMBER1 instead
+        if (playerReader.Version == ClientVersion.SoM)
+        {
+            TargetFocus.BindingID = BindingID.TARGETPARTYMEMBER1;
+        }
+
         var baseActionKeys = GetByType<KeyAction>();
         foreach ((string _, KeyAction keyAction) in baseActionKeys)
         {