Fix lint issues

- Handle unchecked error returns with explicit ignores
- Remove unused codeExecTimes variable
- Convert if-else chain to switch statement
- Remove empty branches in tests

Author: XiaoConstantine

cmd/rlm-viewer/main.go

@@ -219,7 +219,7 @@ func parseLog(filename string) (*LogData, error) {
 	if err != nil {
 		return nil, fmt.Errorf("open file: %w", err)
 	}
-	defer file.Close()
+	defer func() { _ = file.Close() }()
 
 	data := &LogData{Filename: filename}
 	scanner := bufio.NewScanner(file)
@@ -540,7 +540,6 @@ func printDetailedStats(data *LogData) {
 	var totalCodeBlocks, totalLLMCalls int
 	var totalPromptTokens, totalCompletionTokens int
 	var iterTimes []float64
-	var codeExecTimes []float64
 	var llmCallTimes []float64
 
 	for _, iter := range data.Iterations {
@@ -549,7 +548,6 @@ func printDetailedStats(data *LogData) {
 		totalCodeBlocks += len(iter.CodeBlocks)
 
 		for _, block := range iter.CodeBlocks {
-			codeExecTimes = append(codeExecTimes, block.Result.ExecutionTime)
 			for _, call := range block.Result.RLMCalls {
 				totalLLMCalls++
 				totalPromptTokens += call.PromptTokens
@@ -691,7 +689,7 @@ func runInteractive(data *LogData, cfg ViewerConfig) {
 		viewLog(data, cfg)
 		return
 	}
-	defer term.Restore(int(os.Stdin.Fd()), oldState)
+	defer func() { _ = term.Restore(int(os.Stdin.Fd()), oldState) }()
 
 	currentIdx := 0
 	expanded := !cfg.Compact
@@ -716,7 +714,8 @@ func runInteractive(data *LogData, cfg ViewerConfig) {
 			break
 		}
 
-		if n == 1 {
+		switch n {
+		case 1:
 			switch buf[0] {
 			case 'q', 3: // q or Ctrl+C
 				clearScreen()
@@ -746,7 +745,7 @@ func runInteractive(data *LogData, cfg ViewerConfig) {
 					currentIdx = searchResults[searchIdx]
 				}
 			case '/':
-				term.Restore(int(os.Stdin.Fd()), oldState)
+				_ = term.Restore(int(os.Stdin.Fd()), oldState)
 				fmt.Print("\r\033[K/")
 				reader := bufio.NewReader(os.Stdin)
 				query, _ := reader.ReadString('\n')
@@ -756,25 +755,25 @@ func runInteractive(data *LogData, cfg ViewerConfig) {
 				if len(searchResults) > 0 {
 					currentIdx = searchResults[0]
 				}
-				term.MakeRaw(int(os.Stdin.Fd()))
+				_, _ = term.MakeRaw(int(os.Stdin.Fd()))
 			case 's':
 				// Show stats
-				term.Restore(int(os.Stdin.Fd()), oldState)
+				_ = term.Restore(int(os.Stdin.Fd()), oldState)
 				clearScreen()
 				printDetailedStats(data)
 				fmt.Print("\nPress any key to continue...")
-				os.Stdin.Read(make([]byte, 1))
-				term.MakeRaw(int(os.Stdin.Fd()))
+				_, _ = os.Stdin.Read(make([]byte, 1))
+				_, _ = term.MakeRaw(int(os.Stdin.Fd()))
 			case '?':
 				// Show help
-				term.Restore(int(os.Stdin.Fd()), oldState)
+				_ = term.Restore(int(os.Stdin.Fd()), oldState)
 				clearScreen()
 				printInteractiveHelp()
 				fmt.Print("\nPress any key to continue...")
-				os.Stdin.Read(make([]byte, 1))
-				term.MakeRaw(int(os.Stdin.Fd()))
+				_, _ = os.Stdin.Read(make([]byte, 1))
+				_, _ = term.MakeRaw(int(os.Stdin.Fd()))
 			}
-		} else if n == 3 {
+		case 3:
 			// Arrow keys
 			if buf[0] == 27 && buf[1] == 91 {
 				switch buf[2] {

examples/basic/main.go

@@ -167,7 +167,7 @@ func (c *AnthropicClient) doRequest(ctx context.Context, reqBody anthropicReques
 	if err != nil {
 		return "", 0, 0, fmt.Errorf("http request: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	httpTime := time.Since(httpStart)
 
 	readStart := time.Now()
@@ -242,7 +242,7 @@ func main() {
 	if err != nil {
 		fmt.Printf("Warning: could not create logger: %v\n", err)
 	} else {
-		defer log.Close()
+		defer func() { _ = log.Close() }()
 		fmt.Printf("Logging to: %s\n", log.Path())
 	}
 

pkg/core/types_test.go

@@ -52,11 +52,6 @@ func TestExecutionResult(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			// Test that fields are accessible
-			if tt.result.Stdout == "" && tt.result.Stderr == "" {
-				// Empty result is valid
-			}
-
 			hasError := tt.result.Stderr != ""
 			if hasError != tt.hasError {
 				t.Errorf("hasError = %v, want %v", hasError, tt.hasError)
@@ -335,11 +330,12 @@ func TestUsageStats(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			// Verify total is sum of parts (if that's the invariant)
-			expectedTotal := tt.stats.PromptTokens + tt.stats.CompletionTokens
-			if tt.stats.TotalTokens != expectedTotal && tt.stats.TotalTokens != 0 {
-				// Note: This only validates if TotalTokens is set correctly
-				// The actual struct doesn't enforce this invariant
+			// Verify fields are accessible and have expected values
+			if tt.stats.PromptTokens < 0 {
+				t.Errorf("PromptTokens should not be negative: %d", tt.stats.PromptTokens)
+			}
+			if tt.stats.CompletionTokens < 0 {
+				t.Errorf("CompletionTokens should not be negative: %d", tt.stats.CompletionTokens)
 			}
 		})
 	}

pkg/logger/logger.go

@@ -126,7 +126,7 @@ func New(logDir string, cfg Config) (*Logger, error) {
 	}
 
 	if err := l.writeEntry(metadata); err != nil {
-		file.Close()
+		_ = file.Close()
 		return nil, fmt.Errorf("write metadata: %w", err)
 	}
 

pkg/logger/logger_test.go

@@ -66,7 +66,7 @@ func TestNewLogger(t *testing.T) {
 			if err != nil {
 				t.Fatalf("unexpected error: %v", err)
 			}
-			defer logger.Close()
+			defer func() { _ = logger.Close() }()
 
 			// Verify log file was created
 			path := logger.Path()
@@ -140,7 +140,7 @@ func TestLogIteration(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to create logger: %v", err)
 	}
-	defer logger.Close()
+	defer func() { _ = logger.Close() }()
 
 	// Test logging iteration with code blocks
 	prompt := []core.Message{
@@ -257,7 +257,7 @@ func TestLogIterationWithFinalAnswer(t *testing.T) {
 			if err != nil {
 				t.Fatalf("failed to create logger: %v", err)
 			}
-			defer logger.Close()
+			defer func() { _ = logger.Close() }()
 
 			err = logger.LogIteration(
 				1,
@@ -340,7 +340,7 @@ func TestLoggerPath(t *testing.T) {
 	if err != nil {
 		t.Fatalf("failed to create logger: %v", err)
 	}
-	defer logger.Close()
+	defer func() { _ = logger.Close() }()
 
 	path := logger.Path()