ci: capture macOS reranker crash diagnostics

Amp-Thread-ID: https://ampcode.com/threads/T-01a06ea1-0469-74e9-8964-f022065a5f2d
Co-authored-by: do do <dodo0709@fastmail.com>

Author: ampagent

.github/workflows/ci.yml

@@ -10,6 +10,7 @@ jobs:
   test:
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         include:
           # Linux: use sqlite-vec (go-libsql doesn't have Linux prebuilts)
@@ -47,6 +48,17 @@ jobs:
           CGO_LDFLAGS: "-lm"
         run: go test ${{ matrix.tags }} -v -short -race -coverprofile=coverage.txt -covermode=atomic ./...
 
+      - name: Upload macOS crash reports
+        if: failure() && runner.os == 'macOS'
+        uses: actions/upload-artifact@v4
+        with:
+          name: macos-crash-reports-${{ github.run_attempt }}
+          path: |
+            ~/Library/Logs/DiagnosticReports/
+            /Library/Logs/DiagnosticReports/
+          if-no-files-found: warn
+          retention-days: 7
+
       - name: Test portable SIMD kernels
         if: runner.os == 'Linux'
         env:

pkg/rerank/server_test.go

@@ -285,7 +285,7 @@ func TestRerankerSupervisorRetainsLifecycleLockUntilPublication(t *testing.T) {
 			Args:          []string{"30"},
 			Environment:   os.Environ(),
 			Stdout:        io.Discard,
-			Stderr:        io.Discard,
+			Stderr:        os.Stderr,
 			LifecycleLock: supervisorLock,
 			BeforePublish: func() {
 				close(publicationReached)
@@ -828,7 +828,7 @@ func TestRerankerSupervisorUnadoptedLaunchCleansUp(t *testing.T) {
 			Args:            []string{"30"},
 			Environment:     os.Environ(),
 			Stdout:          io.Discard,
-			Stderr:          io.Discard,
+			Stderr:          os.Stderr,
 			AdoptionTimeout: 500 * time.Millisecond,
 		})
 	}()
@@ -872,7 +872,7 @@ func TestRerankerSupervisorUncommittedAdoptionCleansUp(t *testing.T) {
 			Args:            []string{"30"},
 			Environment:     os.Environ(),
 			Stdout:          io.Discard,
-			Stderr:          io.Discard,
+			Stderr:          os.Stderr,
 			AdoptionTimeout: time.Second,
 			AdoptionLease:   300 * time.Millisecond,
 		})
@@ -929,7 +929,7 @@ func TestRerankerManagerStartAdoptsPublishedSupervisor(t *testing.T) {
 				"GO_RERANKER_HELPER_READY="+ready,
 			),
 			Stdout:          io.Discard,
-			Stderr:          io.Discard,
+			Stderr:          os.Stderr,
 			AdoptionTimeout: 400 * time.Millisecond,
 		})
 	}()
@@ -984,7 +984,7 @@ func TestRerankerManagerFailedAdoptionStopsSupervisor(t *testing.T) {
 				"GO_RERANKER_HELPER_READY="+ready,
 			),
 			Stdout:          io.Discard,
-			Stderr:          io.Discard,
+			Stderr:          os.Stderr,
 			AdoptionTimeout: 2 * time.Second,
 		})
 	}()
@@ -1038,7 +1038,7 @@ func TestRerankerSupervisorSIGKILLTerminatesReexecutedRoot(t *testing.T) {
 	supervisor, done, err := launchRerankerSupervisor(currentSupervisorRegistration(t), dir, control, token, port, os.Args[0], []string{
 		"-test.run=TestRerankerHelperProcess", "--",
 		"--port", strconv.Itoa(port), "--pooling", "rank",
-	}, io.Discard)
+	}, os.Stderr)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1113,7 +1113,7 @@ func TestRerankerSupervisorSIGKILLTerminatesForkConfinedChild(t *testing.T) {
 	supervisor, done, err := launchRerankerSupervisor(currentSupervisorRegistration(t), dir, control, token, port, os.Args[0], []string{
 		"-test.run=TestRerankerDescendantHelper", "--",
 		"--port", strconv.Itoa(port), "--pooling", "rank",
-	}, io.Discard)
+	}, os.Stderr)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1180,7 +1180,7 @@ func TestRerankerSupervisorStopPreventsDetachedDescendants(t *testing.T) {
 	supervisor, done, err := launchRerankerSupervisor(currentSupervisorRegistration(t), dir, control, token, port, os.Args[0], []string{
 		"-test.run=TestRerankerDescendantHelper", "--",
 		"--port", strconv.Itoa(port), "--pooling", "rank",
-	}, io.Discard)
+	}, os.Stderr)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1239,7 +1239,7 @@ func TestRerankerSupervisorGuardianFailureTerminatesChild(t *testing.T) {
 	supervisor, done, err := launchRerankerSupervisor(currentSupervisorRegistration(t), dir, control, token, port, os.Args[0], []string{
 		"-test.run=TestRerankerHelperProcess", "--",
 		"--port", strconv.Itoa(port), "--pooling", "rank",
-	}, io.Discard)
+	}, os.Stderr)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1450,7 +1450,7 @@ func TestRerankerSupervisorDoesNotInheritHostDescriptors(t *testing.T) {
 	supervisor, done, err := launchRerankerSupervisor(currentSupervisorRegistration(t), dir, control, token, port, os.Args[0], []string{
 		"-test.run=TestRerankerFDHelper", "--",
 		"--port", strconv.Itoa(port), "--pooling", "rank",
-	}, io.Discard)
+	}, os.Stderr)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1639,7 +1639,7 @@ func startTestRerankerSupervisor(t *testing.T, ignoreTerm bool) (rerankerPIDStat
 			Args:        []string{"-test.run=TestRerankerHelperProcess", "--", "--port", strconv.Itoa(port), "--pooling", "rank"},
 			Environment: environment,
 			Stdout:      io.Discard,
-			Stderr:      io.Discard,
+			Stderr:      os.Stderr,
 		})
 	}()