Redact production ValueError responses

Author: Ankit-Kotnala

src/api/app.py

@@ -114,7 +114,7 @@ def _public_exception_message(exc: Exception) -> str:
     if isinstance(exc, TimeoutError):
         return "The request timed out while waiting for an LLM response."
     if isinstance(exc, ValueError):
-        return message or "Invalid request."
+        return "Invalid request."
     if isinstance(exc, ConnectionError):
         return "A backend service is unavailable. Check the server logs with the request_id for details."
     if isinstance(exc, RuntimeError):

tests/api/test_app_errors.py

@@ -15,6 +15,18 @@ def test_public_exception_message_redacts_connection_details_in_production(monke
     assert "backend service is unavailable" in message
 
 
+def test_public_exception_message_redacts_value_error_in_production(monkeypatch):
+    monkeypatch.setattr(api_app.settings, "environment", "production", raising=False)
+
+    message = api_app._public_exception_message(
+        ValueError("vector mismatch for postgresql://user:password@internal-db:5432/xmem")
+    )
+
+    assert message == "Invalid request."
+    assert "password" not in message
+    assert "internal-db" not in message
+
+
 def test_public_exception_message_keeps_timeout_detail_in_local(monkeypatch):
     monkeypatch.setattr(api_app.settings, "environment", "development", raising=False)