Skip to content

Commit 11367b4

Browse files
Burak Bayırkriptoburak
andauthored
ci: use configured Maven credentials (#9)
Co-authored-by: kriptoburak <kriptoburak@users.noreply.github.com>
1 parent b39cdd0 commit 11367b4

4 files changed

Lines changed: 43 additions & 12 deletions

File tree

.github/workflows/publish-sonatype.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ jobs:
3939
- name: Validate release credentials
4040
run: bash ./bin/check-release-environment
4141
env:
42-
SONATYPE_USERNAME: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME }}
43-
SONATYPE_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD }}
44-
GPG_SIGNING_KEY: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY }}
45-
GPG_SIGNING_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD }}
42+
SONATYPE_USERNAME: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME || secrets.SONATYPE_USERNAME }}
43+
SONATYPE_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD || secrets.SONATYPE_PASSWORD }}
44+
GPG_SIGNING_KEY: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY || secrets.GPG_SIGNING_KEY }}
45+
GPG_SIGNING_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD || secrets.GPG_SIGNING_PASSWORD }}
4646

4747
- name: Publish signed artifacts
4848
shell: bash
@@ -56,7 +56,7 @@ jobs:
5656
--no-daemon \
5757
--stacktrace
5858
env:
59-
ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME }}
60-
ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD }}
61-
GPG_SIGNING_KEY: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY }}
62-
GPG_SIGNING_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD }}
59+
ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME || secrets.SONATYPE_USERNAME }}
60+
ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD || secrets.SONATYPE_PASSWORD }}
61+
GPG_SIGNING_KEY: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY || secrets.GPG_SIGNING_KEY }}
62+
GPG_SIGNING_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD || secrets.GPG_SIGNING_PASSWORD }}

.github/workflows/release-doctor.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ jobs:
3535
- name: Check release environment
3636
run: bash ./bin/check-release-environment
3737
env:
38-
SONATYPE_USERNAME: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME }}
39-
SONATYPE_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD }}
40-
GPG_SIGNING_KEY: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY }}
41-
GPG_SIGNING_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD }}
38+
SONATYPE_USERNAME: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME || secrets.SONATYPE_USERNAME }}
39+
SONATYPE_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD || secrets.SONATYPE_PASSWORD }}
40+
GPG_SIGNING_KEY: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY || secrets.GPG_SIGNING_KEY }}
41+
GPG_SIGNING_PASSWORD: ${{ secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD || secrets.GPG_SIGNING_PASSWORD }}
4242

4343
- name: Build local Maven artifacts
4444
run: ./gradlew publishToMavenLocal -PpublishLocal --no-daemon --stacktrace

bin/check-release-workflow

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
#!/usr/bin/env bash
2+
3+
set -euo pipefail
4+
5+
cd -- "$(dirname -- "$0")/.."
6+
7+
workflows=(
8+
.github/workflows/publish-sonatype.yml
9+
.github/workflows/release-doctor.yml
10+
)
11+
secret_fallbacks=(
12+
"secrets.X_TWITTER_SCRAPER_SONATYPE_USERNAME || secrets.SONATYPE_USERNAME"
13+
"secrets.X_TWITTER_SCRAPER_SONATYPE_PASSWORD || secrets.SONATYPE_PASSWORD"
14+
"secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_KEY || secrets.GPG_SIGNING_KEY"
15+
"secrets.X_TWITTER_SCRAPER_SONATYPE_GPG_SIGNING_PASSWORD || secrets.GPG_SIGNING_PASSWORD"
16+
)
17+
18+
for workflow in "${workflows[@]}"; do
19+
for fallback in "${secret_fallbacks[@]}"; do
20+
if ! grep -Fq "$fallback" "$workflow"; then
21+
printf '%s must support %s.\n' "$workflow" "$fallback"
22+
exit 1
23+
fi
24+
done
25+
done
26+
27+
grep -Fq 'environment: maven-central' .github/workflows/publish-sonatype.yml
28+
29+
printf 'Release workflows use the configured Maven Central secrets.\n'

scripts/lint

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ cd "$(dirname "$0")/.."
66

77
echo "==> Running lints"
88

9+
bash ./bin/check-release-workflow
10+
911
if command -v ktfmt &> /dev/null; then
1012
echo "==> Checking ktfmt"
1113
./scripts/kotlin-format --dry-run --set-exit-if-changed

0 commit comments

Comments
 (0)