test: type-check README quickstart example - #21
Conversation
|
Thanks for the review. I confirmed the failing |
90f657d to
8637e39
Compare
|
Updated this branch on top of the latest Current head is
The GitGuardian and Socket checks on the updated head are green. Ready for re-review. |
furkanerday
left a comment
There was a problem hiding this comment.
DCO blocker: external contributor commit 8637e39 has no author-matching Signed-off-by trailer, contrary to CONTRIBUTING.md. The contributor must amend and re-push this commit with their own valid sign-off; a later maintainer commit cannot cure it.
8637e39 to
cbed75d
Compare
📝 WalkthroughWalkthroughAdds a compile-only TypeScript README quickstart and updates ChangesREADME quickstart type-checking
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Updated the branch again at What changed:
Verification on the updated head:
The two prior requested changes (base dependency audit and contributor DCO sign-off) remain addressed. Ready for re-review on the current head. |
Add a compile-only quickstart example that mirrors the README client setup without sending a request. Run TypeScript checking from the existing test script so the example stays covered by the normal test gate. Signed-off-by: kittydev <108918571+11suixing11@users.noreply.github.com>
cbed75d to
1bc5f76
Compare
Summary
examples/readme-quickstart.tsthat mirrors the README client construction and typed tweet-search params./scripts/testso examples remain covered by the normal test gateFixes #16
Verification
npm exec --yes pnpm@11.15.1 -- install --frozen-lockfile./node_modules/typescript/bin/tsc --project tsconfig.json --noEmit./scripts/test --runInBandnpm exec --yes pnpm@11.15.1 -- run lintnpm exec --yes pnpm@11.15.1 -- run check:reproduciblegit diff --checkNotes
pnpm@11.15.1; this machine's Corepackpnpmshim fails withERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING, so I usednpm exec --yes pnpm@11.15.1 -- ...for pnpm-backed commands.Note
Add type-checking step to test script and README quickstart example
tsc --project tsconfig.json --noEmitbefore executing tests, so type errors fail the build early.Macroscope summarized 1bc5f76.
Summary by CodeRabbit
Documentation
Tests