Skip initial backoff for unprocessed keys during dynamodb restore - #1110
Open
CharlesPeacock wants to merge 1 commit into
Open
Skip initial backoff for unprocessed keys during dynamodb restore#1110CharlesPeacock wants to merge 1 commit into
CharlesPeacock wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
As of recently, Tron has been reaching restart times of over 6 minutes in
pnw-prod. The motivation of this series of PRs is to reduce this number in the safest and most approachable way possible.By not doing
time.sleep()on the first 3 reattempts on_get_itemsafter anUNPROCESSED_KEYSerror, we can save some time since most retrieval errors are fixed on immediate retries.This is the first of many incremental restart improvements.
Tests pass and an existing unit test was modified to reflect new behavior.