Conversation
…ate test documentation - Fixed `reduce_detections` in `frigate/util/object.py` to use `(int, np.integer)` instead of strictly `np.int32` to properly handle non-maxima suppression indices across different OpenCV and Numpy versions. - Executed local tests natively with fallback mocks for dependency verification. - Ran frontend Vitest suite fully successfully. - Executed `cargo test` for all Rust components fully successfully. - Updated documentation in `.zektopic/status.md`, `.zektopic/optimization_and_issues_report.md`, `Jules/improvements.md`, and `Jules/optimization_and_issues_report.md` regarding test outcomes, mocking limitations, and frontend toolchain configurations. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
…object.py - Replaced `list[list[int] | tuple[int, ...]]` with `Sequence[list[int] | tuple[int, ...]]` to satisfy strict typing rules via mypy. - Verified using `mypy --config-file frigate/mypy.ini frigate/util/object.py` Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
1 participant
Fix np.int32 check in reduce_detections causing test failures and update test documentation
reduce_detectionsinfrigate/util/object.pyto use(int, np.integer)instead of strictlynp.int32to properly handle non-maxima suppression indices across different OpenCV and Numpy versions.cargo testfor all Rust components fully successfully..zektopic/status.md,.zektopic/optimization_and_issues_report.md,Jules/improvements.md, andJules/optimization_and_issues_report.mdregarding test outcomes, mocking limitations, and frontend toolchain configurations.PR created automatically by Jules for task 7736248553300896904 started by @manupawickramasinghe