⚡ [Remove LINQ and ToArray allocations in CollectAbandonedGuestImageVersions] - #99
Conversation
…geVersions Replaced `.ToArray()` and `.ToHashSet()`LINQ chains with stack-allocated arrays and `ArrayPool<long>` fallbacks to eliminate per-frame allocations during abandoned guest image version cleanup. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…geVersions Replaced `.ToArray()` and `.ToHashSet()`LINQ chains with stack-allocated arrays and `ArrayPool<long>` fallbacks to eliminate per-frame allocations during abandoned guest image version cleanup. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
📦 Build artifacts —
|
| Platform | Download |
|---|---|
| Windows (win-x64) | sharpemu-win-x64-b19c99e |
| Linux (linux-x64) | sharpemu-linux-x64-b19c99e |
| macOS (osx-x64) | sharpemu-osx-x64-b19c99e |
From build run #241. Downloads require a GitHub login and expire after 90 days.
💡 What
Replaced LINQ chains (
.Select,.Where,.ToHashSet) and.ToArray()enumerations inCollectAbandonedGuestImageVersionswith stack-allocated arrays (Span<long> stackalloc long[8]andSpan<long> stackalloc long[64]) combined with standard manual loops.Included a fallback to
System.Buffers.ArrayPool<long>.Sharedfor edge cases where the dictionary count exceeds the 64-element stackalloc limit for theabandonedVersionslist.🎯 Subsystem & Bottleneck
Subsystem: VideoOut / VulkanVideoPresenter
Bottleneck: In
CollectAbandonedGuestImageVersions,_guestImageVersions.ToArray()was called every frame to safely enumerate a dictionary while modifying it. This, along with.ToHashSet()for tracked versions, caused multiple array and HashSet allocations on the heap every frame, driving up Garbage Collection overhead in the critical render/presentation path.📜 Git & Contributor Context
The issue flagged the unnecessary
_guestImageVersions.ToArray()call during the teardown loop.📊 Measured Performance Impact
.ToArray()allocation, and theHashSetallocation per frame.stackalloc).🔬 Verification Checklist
dotnet test tests/SharpEmu.Libs.Tests/SharpEmu.Libs.Tests.csproj(941/941 passed)lock(_gate)remain exactly as they were.PR created automatically by Jules for task 7466405454377917510 started by @manupawickramasinghe