ci: publish with Node 24 - #644
Merged
Merged
Conversation
The shared publish workflow upgrades npm to latest for OIDC support. npm 12 requires Node 24, so the publish step failed with EBADENGINE on Node 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared publish workflow (
_publish-npm.yaml@v6) runsnpm install -g npm@latestbefore publishing. npm 12 requires Node 24, so the v0.68.0 publish failed withEBADENGINEon Node 22.22.1: https://github.com/Zondax/zemu/actions/runs/34255411472This passes
node_version: "24"to the workflow. It only affects the publish job; CI and the package'senginesfield are unchanged.