Skip to content

Commit 067f987

Browse files
committed
refactor(task): make disk guards mutation-visible
1 parent eeaa94d commit 067f987

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

‎src/core/task-persistence/TaskHistoryStore.ts‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,7 @@ export class TaskHistoryStore {
891891
lockAcquired: options?.lockAcquired,
892892
merge: (existing, incoming) => {
893893
if (diskGuard) {
894-
if (!existing || typeof existing !== "object" || !("id" in existing)) {
894+
if (Object(existing) !== existing || !("id" in (existing as object))) {
895895
throw new Error(`[TaskHistoryStore] guarded write: task ${item.id} not found on disk`)
896896
}
897897
diskGuard(existing as HistoryItem)
@@ -1162,12 +1162,11 @@ export class TaskHistoryStore {
11621162

11631163
try {
11641164
let firstDiskSnapshot: HistoryItem | undefined
1165+
const firstDiskGuard = options?.firstDiskGuard
11651166
const captureAndGuardFirst =
1166-
options?.firstDiskGuard ||
1167-
options?.rollbackFirstOnSecondFailure ||
1168-
options?.rollbackBothOnCallbackFailure
1167+
firstDiskGuard || options?.rollbackFirstOnSecondFailure || options?.rollbackBothOnCallbackFailure
11691168
? (current: HistoryItem) => {
1170-
options?.firstDiskGuard?.(current)
1169+
if (firstDiskGuard) firstDiskGuard(current)
11711170
firstDiskSnapshot = structuredClone(current)
11721171
}
11731172
: undefined

0 commit comments

Comments
 (0)