@@ -177,6 +177,77 @@ describe("SkillsManager", () => {
177177 await skillsManager . dispose ( )
178178 } )
179179
180+ describe ( "frontmatter security" , ( ) => {
181+ const skillDir = p ( projectSkillsDir , "test-skill" )
182+ const skillPath = p ( skillDir , "SKILL.md" )
183+ const valid = "---\nname: test-skill\ndescription: Test skill\n---\nInstructions"
184+
185+ beforeEach ( ( ) => {
186+ mockDirectoryExists . mockImplementation ( async ( dir : string ) => dir === projectSkillsDir )
187+ mockRealpath . mockImplementation ( async ( value : string ) => value )
188+ mockReaddir . mockImplementation ( async ( dir : string ) => ( dir === projectSkillsDir ? [ "test-skill" ] : [ ] ) )
189+ mockStat . mockResolvedValue ( { isDirectory : ( ) => true } )
190+ mockFileExists . mockImplementation ( async ( file : string ) => file === skillPath )
191+ mockReadFile . mockResolvedValue ( valid )
192+ } )
193+
194+ it . each ( [ "javascript" , "js" , "JavaScript" , "coffee" , "unknown" ] ) (
195+ "rejects %s at discovery and after the file changes" ,
196+ async ( language ) => {
197+ const execute = vi . fn ( )
198+ vi . stubGlobal ( "__skillFrontmatterProbe" , execute )
199+ try {
200+ await skillsManager . discoverSkills ( )
201+ const unsafe = `\uFEFF---${ language } \n(globalThis.__skillFrontmatterProbe(), {name: "test-skill", description: "Test"})\n---\nBody`
202+ mockReadFile . mockResolvedValue ( unsafe )
203+ await expect ( skillsManager . getSkillContent ( "test-skill" ) ) . rejects . toThrow ( "Unsupported frontmatter" )
204+ await expect ( skillsManager . updateSkillModes ( "test-skill" , "project" , [ "code" ] ) ) . rejects . toThrow (
205+ "Unsupported frontmatter" ,
206+ )
207+ await skillsManager . discoverSkills ( )
208+ expect ( skillsManager . getAllSkills ( ) ) . toEqual ( [ ] )
209+ expect ( mockWriteFile ) . not . toHaveBeenCalled ( )
210+ expect ( execute ) . not . toHaveBeenCalled ( )
211+ } finally {
212+ vi . unstubAllGlobals ( )
213+ }
214+ } ,
215+ )
216+
217+ it . each ( [ "" , "yaml" , "yml" , "json" ] ) (
218+ "accepts data frontmatter %s through all entry points" ,
219+ async ( language ) => {
220+ const metadata =
221+ language === "json"
222+ ? '{"name":"test-skill","description":"Test skill"}'
223+ : "name: test-skill\ndescription: Test skill"
224+ mockReadFile . mockResolvedValue ( `---${ language } \n${ metadata } \n---\nInstructions` )
225+ await skillsManager . discoverSkills ( )
226+ expect ( skillsManager . getAllSkills ( ) ) . toHaveLength ( 1 )
227+ await expect ( skillsManager . getSkillContent ( "test-skill" ) ) . resolves . toMatchObject ( {
228+ instructions : "Instructions" ,
229+ } )
230+ await skillsManager . updateSkillModes ( "test-skill" , "project" , [ "code" ] )
231+ expect ( mockWriteFile ) . toHaveBeenCalledWith ( skillPath , expect . stringContaining ( "modeSlugs:" ) , "utf-8" )
232+ } ,
233+ )
234+
235+ it ( "preserves executable-looking body text during mode updates without parsing it" , async ( ) => {
236+ const execute = vi . fn ( )
237+ vi . stubGlobal ( "__skillBodyProbe" , execute )
238+ try {
239+ const body = "---js\n(globalThis.__skillBodyProbe())\n---\nBody"
240+ mockReadFile . mockResolvedValue ( valid . replace ( "Instructions" , body ) )
241+ await skillsManager . discoverSkills ( )
242+ await skillsManager . updateSkillModes ( "test-skill" , "project" , [ "code" ] )
243+ expect ( execute ) . not . toHaveBeenCalled ( )
244+ expect ( mockWriteFile ) . toHaveBeenCalledWith ( skillPath , expect . stringContaining ( body ) , "utf-8" )
245+ } finally {
246+ vi . unstubAllGlobals ( )
247+ }
248+ } )
249+ } )
250+
180251 describe ( "discoverSkills" , ( ) => {
181252 it ( "should discover skills from global directory" , async ( ) => {
182253 const pdfSkillDir = p ( globalSkillsDir , "pdf-processing" )
0 commit comments