Repository navigation
Commit 3b825bf
[Fix] Five webview visual tests fail on every pull request (#2209)
* test(webview): refresh stale toolkit baselines missed by #2163
Regenerate the five baselines that #2163 left on the mocked toolkit
rendering: history-rename-editor in all four themes and
opencode-go-temperature. Captured by the pinned
mcr.microsoft.com/playwright:v1.62.1-noble container via the Visual
Regression workflow on this branch.
The real toolkit places the search field's icon inline inside the field
and renders the custom-temperature checkbox inline with its label
(480x359 -> 480x340), matching the intended appearance from #2163.
Fixes #2206
* ci(webview): drop pull_request path filter from Visual Regression
The Protect Main ruleset should require the webview-visual check. GitHub
keeps path-filtered workflows in a pending state on pull requests that
do not match the filter, so a required check would block those PRs from
merging. Remove the pull_request paths filter so webview-visual,
theme-fixtures, and extension-host-visual report on every pull request,
like code-qa and e2e already do. The merge_group event ignores path
filters, so merge-queue runs are unchanged.
---------
Co-authored-by: Roomote <roomote@roomote.dev>1 parent 764db84 commit 3b825bf
6 files changed
Lines changed: 4 additions & 15 deletions
File tree
- .github/workflows
- webview-ui/src/components
- history/__tests__/__screenshots__
- settings/__tests__/__screenshots__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
5 | 9 | | |
6 | 10 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 11 | | |
23 | 12 | | |
24 | 13 | | |
| |||
0 commit comments