Repository navigation
Commit 836e2e0
committed
u1: move the two profile-record declarations to the units that carry their readers
sharedStoreCarriesProfileRecord is called only from the hunk unit 3 carries (1921 head ClineProvider.ts:3840);
ProfileActivationInconsistentError is used only from the hunks unit 2 carries (1921 head :3350 and :4465).
Carrying a declaration whose readers live in another unit leaves it unreachable in the unit that owns it, which
is what made eslint report 2 no-unused-vars problems on this unit, and it is the carrier rule broken in the
opposite direction from the guard test: the guard travelled with its readers, these two did not. Both
declarations move out of this unit and no call site moves to keep a declaration in place. Until unit 3's head
exists on a remote, sharedStoreCarriesProfileRecord exists in no pushed ref, which the unit body and the plan
of record say rather than smooth over.
Hooks: state this plainly. This commit is being made in the campaign scratch worktree where pnpm 10.8.1 is on
PATH and where this round ran check-types and eslint, so husky's pre-commit is able to run; the hook result for
this commit is recorded in the campaign ledger for this round from the commit's own output, not asserted here.1 parent bece7f0 commit 836e2e0
1 file changed
Lines changed: 0 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | 256 | | |
285 | 257 | | |
286 | 258 | | |
| |||
0 commit comments