chore(lint): flag unneeded type assertions in api/

Author: edelauna

src/api/providers/anthropic-vertex.ts

@@ -143,7 +143,7 @@ export class AnthropicVertexHandler extends BaseProvider implements SingleComple
 			for await (const chunk of stream) {
 				switch (chunk.type) {
 					case "message_start": {
-						const usage = chunk.message!.usage
+						const usage = chunk.message.usage
 
 						// `output_tokens_details.thinking_tokens` decomposes the billed
 						// output into internal reasoning tokens; surfaced for per-turn
@@ -155,19 +155,19 @@ export class AnthropicVertexHandler extends BaseProvider implements SingleComple
 							cacheWriteTokens: usage.cache_creation_input_tokens || undefined,
 							cacheReadTokens: usage.cache_read_input_tokens || undefined,
 							...(typeof usage.output_tokens_details?.thinking_tokens === "number"
-								? { reasoningTokens: usage.output_tokens_details!.thinking_tokens }
+								? { reasoningTokens: usage.output_tokens_details.thinking_tokens }
 								: {}),
 						}
 
 						break
 					}
 					case "message_delta": {
-						const deltaThinkingTokens = chunk.usage!.output_tokens_details?.thinking_tokens
+						const deltaThinkingTokens = chunk.usage.output_tokens_details?.thinking_tokens
 
 						yield {
 							type: "usage",
 							inputTokens: 0,
-							outputTokens: chunk.usage!.output_tokens || 0,
+							outputTokens: chunk.usage.output_tokens || 0,
 							...(typeof deltaThinkingTokens === "number"
 								? { reasoningTokens: deltaThinkingTokens }
 								: {}),
@@ -176,17 +176,17 @@ export class AnthropicVertexHandler extends BaseProvider implements SingleComple
 						break
 					}
 					case "content_block_start": {
-						switch (chunk.content_block!.type) {
+						switch (chunk.content_block.type) {
 							case "text": {
-								if (chunk.index! > 0) {
+								if (chunk.index > 0) {
 									yield { type: "text", text: "\n" }
 								}
 
-								yield { type: "text", text: chunk.content_block!.text }
+								yield { type: "text", text: chunk.content_block.text }
 								break
 							}
 							case "thinking": {
-								if (chunk.index! > 0) {
+								if (chunk.index > 0) {
 									yield { type: "reasoning", text: "\n" }
 								}
 
@@ -198,8 +198,8 @@ export class AnthropicVertexHandler extends BaseProvider implements SingleComple
 								yield {
 									type: "tool_call_partial",
 									index: chunk.index,
-									id: chunk.content_block!.id,
-									name: chunk.content_block!.name,
+									id: chunk.content_block.id,
+									name: chunk.content_block.name,
 									arguments: undefined,
 								}
 								break
@@ -209,9 +209,9 @@ export class AnthropicVertexHandler extends BaseProvider implements SingleComple
 						break
 					}
 					case "content_block_delta": {
-						switch (chunk.delta!.type) {
+						switch (chunk.delta.type) {
 							case "text_delta": {
-								yield { type: "text", text: chunk.delta!.text }
+								yield { type: "text", text: chunk.delta.text }
 								break
 							}
 							case "thinking_delta": {

src/api/providers/anthropic.ts

@@ -32,7 +32,7 @@ import {
 // Pre-sorted list of known Anthropic model IDs (lowercased) by length (descending) for case-insensitive substring matching.
 const ANTHROPIC_MODEL_IDS_SORTED_LOWER = (Object.keys(anthropicModels) as AnthropicModelId[])
 	.map((id) => id.toLowerCase())
-	.sort((a, b) => b.length - a.length) as string[]
+	.sort((a, b) => b.length - a.length)
 
 // Original-case mapping: lowercase key → original AnthropicModelId for lookup.
 const ANTHROPIC_MODEL_ID_LOWER_TO_ORIGINAL = Object.fromEntries(
@@ -400,7 +400,7 @@ export class AnthropicHandler extends BaseProvider implements SingleCompletionHa
 			return anthropicModels[anthropicDefaultModelId]
 		}
 
-		const originalId = ANTHROPIC_MODEL_ID_LOWER_TO_ORIGINAL[matchedLower] as AnthropicModelId
+		const originalId = ANTHROPIC_MODEL_ID_LOWER_TO_ORIGINAL[matchedLower]
 		return anthropicModels[originalId]
 	}
 

src/api/providers/nanogpt.ts

@@ -9,7 +9,6 @@ import {
 	providerIdentifiers,
 	type ModelInfo,
 	type ModelRecord,
-	type NanoGptRoutingPreference,
 	type ReasoningEffortExtended,
 } from "@roo-code/types"
 
@@ -115,10 +114,7 @@ export class NanoGptHandler extends RouterProvider implements SingleCompletionHa
 	}
 
 	private getRequestModelId(canonicalModelId: string): string {
-		return applyNanoGptRoutingPreference(
-			canonicalModelId,
-			this.options.nanoGptRoutingPreference as NanoGptRoutingPreference | undefined,
-		)
+		return applyNanoGptRoutingPreference(canonicalModelId, this.options.nanoGptRoutingPreference)
 	}
 
 	private createSafeError(operation: string, error: unknown): Error {

src/api/providers/openai-codex.ts

@@ -627,7 +627,7 @@ export class OpenAiCodexHandler extends BaseProvider implements SingleCompletion
 						if (block.type === "text") {
 							content.push({ type: "input_text", text: block.text })
 						} else if (block.type === "image") {
-							const image = block as Anthropic.Messages.ImageBlockParam
+							const image = block
 							if (image.source.type === "base64") {
 								const imageUrl = `data:${image.source.media_type};base64,${image.source.data}`
 								content.push({ type: "input_image", image_url: imageUrl })

src/api/providers/openai-native.ts

@@ -145,8 +145,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 			usage.cache_read_input_tokens ?? usage.cache_read_tokens ?? usage.cached_tokens ?? cachedFromDetails ?? 0
 
 		// Resolve effective tier: prefer actual tier from response; otherwise requested tier
-		const effectiveTier =
-			this.lastServiceTier || (this.options.openAiNativeServiceTier as ServiceTier | undefined) || undefined
+		const effectiveTier = this.lastServiceTier || this.options.openAiNativeServiceTier || undefined
 		const effectiveInfo = this.applyServiceTierPricing(model.info, effectiveTier)
 
 		// Pass total input tokens directly to calculateApiCostOpenAI
@@ -486,7 +485,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 						if (block.type === "text") {
 							content.push({ type: "input_text", text: block.text })
 						} else if (block.type === "image") {
-							const image = block as Anthropic.Messages.ImageBlockParam
+							const image = block
 							if (image.source.type === "base64") {
 								const imageUrl = `data:${image.source.media_type};base64,${image.source.data}`
 								content.push({ type: "input_image", image_url: imageUrl })
@@ -1551,7 +1550,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 
 			// Include text.verbosity only when the model explicitly supports it
 			if (model.info.supportsVerbosity === true) {
-				requestBody.text = { verbosity: (verbosity || "medium") as VerbosityLevel }
+				requestBody.text = { verbosity: verbosity || "medium" }
 			}
 
 			// Enable extended prompt cache retention for eligible models

src/api/providers/xai.ts

@@ -62,14 +62,6 @@ export class XAIHandler extends BaseProvider implements SingleCompletionHandler
 		return { id, info, ...params }
 	}
 
-	/**
-	 * Convert tools from OpenAI Chat Completions format to Responses API format.
-	 * Chat Completions: { type: "function", function: { name, description, parameters } }
-	 * Responses API: { type: "function", name, description, parameters }
-	 *
-	 * Uses base provider's convertToolSchemaForOpenAI() for schema hardening
-	 * (additionalProperties: false, ensureAllRequired) and handles MCP tools.
-	 */
 	/**
 	 * Map a Chat Completions tool choice to the Responses API shape so TypeScript
 	 * validates the provider payload (the APIs use different object forms for the
@@ -125,6 +117,14 @@ export class XAIHandler extends BaseProvider implements SingleCompletionHandler
 		}
 	}
 
+	/**
+	 * Convert tools from OpenAI Chat Completions format to Responses API format.
+	 * Chat Completions: { type: "function", function: { name, description, parameters } }
+	 * Responses API: { type: "function", name, description, parameters }
+	 *
+	 * Uses base provider's convertToolSchemaForOpenAI() for schema hardening
+	 * (additionalProperties: false, ensureAllRequired) and handles MCP tools.
+	 */
 	private mapResponseTools(tools?: any[]): any[] | undefined {
 		const converted = this.convertToolsForOpenAI(tools)
 		if (!converted?.length) {
@@ -200,7 +200,7 @@ export class XAIHandler extends BaseProvider implements SingleCompletionHandler
 			let stream: AsyncIterable<any>
 			try {
 				stream = (await this.client.responses.create(
-					{ ...requestBody, stream: true } as any,
+					requestBody,
 					abortSignal ? { signal: abortSignal } : undefined,
 				)) as unknown as AsyncIterable<any>
 			} catch (error) {

src/api/transform/model-params.ts

@@ -137,7 +137,7 @@ export function getModelParams({
 		// Here we simply propagate the resolved effort into the params, while
 		// still treating "disable" as an omission.
 		if (effort && effort !== "disable") {
-			reasoningEffort = effort as ReasoningEffortExtended
+			reasoningEffort = effort
 		}
 	}
 

src/api/transform/openai-format.ts

@@ -465,7 +465,7 @@ export function convertToOpenAiMessages(
 						] as OpenAI.Chat.ChatCompletionToolMessageParam
 						if (lastToolMessage?.role === "tool") {
 							const additionalText = filteredNonToolMessages
-								.map((part) => sanitizeSurrogates((part as Anthropic.TextBlockParam).text))
+								.map((part) => sanitizeSurrogates(part.text))
 								.join("\n")
 							lastToolMessage.content = `${lastToolMessage.content}\n\n${additionalText}`
 						}

src/api/transform/reasoning.ts

@@ -63,7 +63,7 @@ export const getOpenRouterReasoning = ({
 		? { max_tokens: reasoningBudget }
 		: shouldUseReasoningEffort({ model, settings })
 			? reasoningEffort && reasoningEffort !== "disable"
-				? { effort: reasoningEffort as ReasoningEffortExtended }
+				? { effort: reasoningEffort }
 				: undefined
 			: undefined
 
@@ -185,8 +185,7 @@ export const getGeminiReasoning = ({
 	// We intentionally ignore enableReasoningEffort here so that explicitly chosen
 	// efforts in the UI (e.g. "High" for gemini-3-pro-preview) always translate
 	// into a thinkingConfig, regardless of legacy boolean flags.
-	const selectedEffort = (settings.reasoningEffort ?? model.reasoningEffort) as
-		ReasoningEffortExtended | "disable" | undefined
+	const selectedEffort = settings.reasoningEffort ?? model.reasoningEffort
 
 	// Respect "off" / unset semantics from the effort selector itself.
 	if (!selectedEffort || selectedEffort === "disable") {

src/eslint-suppressions.json

@@ -446,7 +446,7 @@
 	},
 	"api/providers/xai.ts": {
 		"@typescript-eslint/no-explicit-any": {
-			"count": 5
+			"count": 4
 		}
 	},
 	"api/transform/__tests__/ai-sdk.spec.ts": {