Skip to content

fix(auto-approval): extract nested shell substitutions for allowlist #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaubnerF wants to merge 41 commits into
base: main
Choose a base branch
from
Open

fix(auto-approval): extract nested shell substitutions for allowlist #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d32e69f
fix(auto-approval): extract nested shell substitutions for allowlist
DaubnerF Oct 15, 2026
4001662
fix(auto-approval): close CodeRabbit review findings in command parser
DaubnerF Oct 17, 2026
7316cc7
fix(auto-approval): inspect arithmetic interiors and fix heredoc deli…
DaubnerF Oct 17, 2026
076ebee
fix(auto-approval): heredoc terminator join order and CR-bounded line…
DaubnerF Oct 17, 2026
c69a96b
fix(auto-approval): fail closed on CR-touched heredocs (#1947)
DaubnerF Oct 18, 2026
a199b50
Merge remote-tracking branch 'upstream/main' into fix/1947-substituti…
DaubnerF Oct 18, 2026
bc00ba2
fix(auto-approval): fail closed on CR in no-delimiter heredocs (#1947)
DaubnerF Oct 18, 2026
c44c4d3
perf: bound heredoc CR scan to the masked span
DaubnerF Oct 18, 2026
c2cd08a
fix: close heredoc fail-open and relax depth-0 closers
DaubnerF Oct 20, 2026
d5bd1bf
test: pin exact parser decisions and correct comment claims
DaubnerF Oct 21, 2026
9886548
fix: close heredoc opener-remainder fail-open inside substitutions
DaubnerF Oct 22, 2026
d71c234
Merge remote-tracking branch 'upstream/main' into fix/1947-substituti…
DaubnerF Oct 23, 2026
61bf7b9
test: re-pin procsub closer placeholder for shell-quote 1.12 tokeniza…
DaubnerF Oct 23, 2026
cdac899
fix: run $(( ... ) ... ) groups through the command-substitution path
DaubnerF Oct 23, 2026
c9cbad6
fix: close heredoc opener-line fail-opens and the fallback fail-open
DaubnerF Oct 26, 2026
266aa42
test: pin allow and deny decisions for the hidden heredoc substitution
DaubnerF Oct 26, 2026
a6de355
fix: flush segments at |& and skip discarded heredoc opener comments
DaubnerF Oct 28, 2026
2201238
test: pin allow and deny decisions for the |& pipeline split
DaubnerF Oct 28, 2026
95ed88d
test: pin word-start # comment onsets on heredoc opener lines
DaubnerF Oct 29, 2026
7d0c34d
fix: close glued-# and backslash-newline heredoc fail-opens
DaubnerF Nov 1, 2026
f3fd221
chore: reword the onset-row preamble and a directive reason
DaubnerF Nov 1, 2026
6230041
Merge remote-tracking branch 'upstream/main' into fix/1947-substituti…
DaubnerF Nov 1, 2026
72aba0c
refactor: drop unused parser export, route tests through parseCommand
DaubnerF Nov 1, 2026
acacfbb
Merge remote-tracking branch 'origin/main' into fix/1947-substitution…
DaubnerF Nov 2, 2026
bccbd38
fix: treat a herestring inside a command substitution as one operator
DaubnerF Nov 2, 2026
57b52a9
fix: close parser blind spots that hide substitutions bash executes
DaubnerF Nov 4, 2026
1953cb5
fix: treat ANSI-C quoted words as opaque in the command parser
DaubnerF Nov 5, 2026
31adbd8
fix: close unclosed-quote and nested-comment gaps in the command parser
DaubnerF Nov 5, 2026
6b6230e
fix: treat # after an escaped blank inside a substitution as word text
DaubnerF Nov 5, 2026
5f43b4c
test: pin a # comment after a real blank inside a process substitution
DaubnerF Nov 5, 2026
e8fabe1
Merge remote-tracking branch 'upstream/main' into fix/1947-substituti…
DaubnerF Nov 6, 2026
dc59077
fix: stop treating backslash-newline as a word-continuation escape pair
DaubnerF Nov 6, 2026
3fb8a75
fix: refuse heredocs whose delimiter contains ANSI-C or locale quoting
DaubnerF Nov 6, 2026
0b02ab6
fix: recognize substitution openers a line continuation forms
DaubnerF Nov 8, 2026
05b34c8
test: rename the joined-substitution fixture marker
DaubnerF Nov 8, 2026
38bc779
fix: emit each nested substitution payload once
DaubnerF Nov 9, 2026
f63d490
refactor: drop nested-payload guards the push already enforced
DaubnerF Nov 9, 2026
c4d213f
fix(auto-approval): keep tokenizer-failure warning content-free
DaubnerF Nov 9, 2026
1f36586
test(auto-approval): isolate opener-CR rejection and pin the tokenize…
DaubnerF Nov 9, 2026
79e5fcd
fix(auto-approval): fail closed on CR-ambiguous brace openers and pay…
DaubnerF Nov 9, 2026
4d4a1c8
fix(auto-approval): keep parse-error messages free of input echoes
DaubnerF Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading