From c67e814b4be9167914639b4dd1616bfdec3ba444 Mon Sep 17 00:00:00 2001 From: Elliott de Launay Date: Mon, 16 Nov 2026 22:19:25 +0000 Subject: [PATCH] test(frontmatter): cover json skills, YAML tags and more languages --- docs/architecture/tla/Frontmatter.tla | 1 + .../skills/__tests__/SkillsManager.spec.ts | 14 ++++++++++++++ src/utils/__tests__/safeFrontmatter.spec.ts | 6 +++++- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/docs/architecture/tla/Frontmatter.tla b/docs/architecture/tla/Frontmatter.tla index 6f85db78c5..8dd6a37031 100644 --- a/docs/architecture/tla/Frontmatter.tla +++ b/docs/architecture/tla/Frontmatter.tla @@ -11,6 +11,7 @@ \* Cost: TLC runs in under 1 second. Agent time is not measured. \* Review: 1 covered (bot thread on double BOM, PR 2455), 0 added, 1 gap. \* Gap: PR 2456 bot thread on uppercase YAML. The spec models safety only, not false rejects. A test covers it. +\* Gap: a YAML tag such as !!js/function is not a header language. The spec cannot express it. A test covers it. \* Replay: two BOMs do not run code in gray-matter. It is a false alarm. A test case stays. \* Skills: the skill caller is the same input domain. The skill path was unguarded before this change. \* Property test: src/utils/__tests__/safeFrontmatter.spec.ts. Caller tests: SkillsManager.spec.ts, frontmatter-commands.spec.ts. diff --git a/src/services/skills/__tests__/SkillsManager.spec.ts b/src/services/skills/__tests__/SkillsManager.spec.ts index 68fe0ecd67..4e1beb99ff 100644 --- a/src/services/skills/__tests__/SkillsManager.spec.ts +++ b/src/services/skills/__tests__/SkillsManager.spec.ts @@ -218,6 +218,20 @@ describe("SkillsManager", () => { } }) + it.each(["", "yaml", "json"])("accepts data-only %s metadata in skill operations", async (language) => { + mockDirectoryExists.mockImplementation(async (dir: string) => dir === projectSkillsDir) + mockRealpath.mockImplementation(async (value: string) => value) + mockReaddir.mockImplementation(async (dir: string) => (dir === projectSkillsDir ? ["example"] : [])) + mockStat.mockResolvedValue({ isDirectory: () => true }) + mockFileExists.mockResolvedValue(true) + const metadata = + language === "json" ? '{"name":"example","description":"Example"}' : "name: example\ndescription: Example" + mockReadFile.mockResolvedValue(`---${language}\n${metadata}\n---\nBody`) + await skillsManager.discoverSkills() + expect(skillsManager.getAllSkills()).toHaveLength(1) + expect((await skillsManager.getSkillContent("example"))?.instructions).toBe("Body") + }) + describe("discoverSkills", () => { it("should discover skills from global directory", async () => { const pdfSkillDir = p(globalSkillsDir, "pdf-processing") diff --git a/src/utils/__tests__/safeFrontmatter.spec.ts b/src/utils/__tests__/safeFrontmatter.spec.ts index c6fb91fea2..f7d95589bd 100644 --- a/src/utils/__tests__/safeFrontmatter.spec.ts +++ b/src/utils/__tests__/safeFrontmatter.spec.ts @@ -9,7 +9,7 @@ describe("parseFrontmatter", () => { }) }) - it.each(["javascript", "js", "JavaScript", "JS", " javascript ", "toml"])( + it.each(["javascript", "js", "JavaScript", "JS", " javascript ", "toml", "coffee", "__proto__"])( "rejects %s before executing metadata, including with a BOM", (language) => { for (const prefix of ["", "\uFEFF"]) { @@ -47,6 +47,10 @@ describe("parseFrontmatter", () => { }) }) + it("rejects executable YAML tags", () => { + expect(() => parseFrontmatter('---\nvalue: !!js/function "function () {}"\n---')).toThrow() + }) + it("preserves Markdown without metadata", () => { expect(parseFrontmatter("# Heading\nBody").content).toBe("# Heading\nBody") })