Skip to content

Prevent code execution when reading and updating skill frontmatter - #2465

Merged
edelauna merged 1 commit into
mainfrom
coderabbit/secure-workspace-frontmatter-parsing/fe910c92
Nov 16, 2026
Merged

edelauna merged 1 commit into
mainfrom
coderabbit/secure-workspace-frontmatter-parsing/fe910c92

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Share the command frontmatter guard with skill discovery, content reads, and mode updates. Reject unsupported engines before parsing, including headers with a leading BOM. Continue to accept YAML and JSON metadata.

Serialize mode updates without parsing skill body text as frontmatter. Add regression tests for rejected engines, accepted formats, changed files, and executable-looking body text.

This change supports reliability. No user documentation updates are required.

Validation: Tests were not run during this inspection. No related issue number was provided.

View coding task

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: The required review sequence passed. Remaining merge requirements apply.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Changed-code mutation testing

No mutants survived the changed-code mutation run for head 0b02b276277c.

The changed-code-mutation-report artifact on this workflow run contains the full reports.

@github-actions github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer has-conflicts PR has merge conflicts with the base branch awaiting-author PR is waiting for the author to address requested changes and removed awaiting-maintainer CodeRabbit approved; waiting for a human maintainer labels Nov 16, 2026
@edelauna
edelauna force-pushed the coderabbit/secure-workspace-frontmatter-parsing/fe910c92 branch from 204f18f to 0b02b27 Compare November 16, 2026 23:11
@github-actions github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer and removed has-conflicts PR has merge conflicts with the base branch awaiting-author PR is waiting for the author to address requested changes labels Nov 16, 2026
@edelauna
edelauna added this pull request to the merge queue Nov 16, 2026
@github-actions github-actions Bot removed the awaiting-maintainer CodeRabbit approved; waiting for a human maintainer label Nov 16, 2026
Merged via the queue into main with commit dc6d143 Nov 16, 2026
23 checks passed
@edelauna
edelauna deleted the coderabbit/secure-workspace-frontmatter-parsing/fe910c92 branch November 16, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant