Fix: Remove duplicate non-adjacent points in movement geometry - #1171
Open
zeofr wants to merge 1 commit into
Open
Fix: Remove duplicate non-adjacent points in movement geometry#1171zeofr wants to merge 1 commit into
zeofr wants to merge 1 commit into
Conversation
Fixes a-b-street#1157 by deduplicating all points (not just consecutive ones) before creating movement polylines. Uses a 1cm epsilon tolerance for floating point comparison to handle near-duplicate points. Tested successfully: - Cairo map imports without 'dupe non-adjacent pts' warnings - Map loads and displays correctly in sandbox mode - All map_model tests pass
|
I hit this same panic importing Cairo urban core (~364K movements). I have a NaN-safe fallback fix ready — would a PR be welcome? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1157
Fixes #1157 by deduplicating all points (not just consecutive ones) before creating movement polylines. Uses a 1cm epsilon tolerance for floating point comparison to handle near-duplicate points.
Tested successfully: