Repository navigation
Commit 03f2499
enhance: Add Task final state auto-close to JSONRPC and REST client transports
Enhance client-side auto-close logic to handle both TaskStatusUpdateEvent and
Task objects with final states. This handles edge cases like late subscriptions
to already-completed tasks and ensures no connection leaks in any scenario.
Changes:
- SSEEventListener (JSONRPC): Check both TaskStatusUpdateEvent.isFinal() and
Task.status().state().isFinal() before closing connection
- RestSSEEventListener (REST): Add complete auto-close logic (was missing entirely)
- Pass future parameter through to handleMessage()
- Check both event types for final states
- Both transports now have identical, defensive auto-close behavior
Benefits:
- Handles late subscriptions to completed tasks gracefully
- Prevents connection leaks in all scenarios (not just TaskStatusUpdateEvent)
- Consistent behavior across JSONRPC and REST transports
- Defensive programming - better to close on final events than leak connections
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 14afb27 commit 03f2499
2 files changed
Lines changed: 37 additions & 7 deletions
File tree
- client/transport
- jsonrpc/src/main/java/io/a2a/client/transport/jsonrpc/sse
- rest/src/main/java/io/a2a/client/transport/rest/sse
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
74 | 80 | | |
75 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
76 | 86 | | |
77 | 87 | | |
78 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
| |||
29 | 32 | | |
30 | 33 | | |
31 | 34 | | |
32 | | - | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| |||
44 | 47 | | |
45 | 48 | | |
46 | 49 | | |
47 | | - | |
| 50 | + | |
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
| |||
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
65 | 85 | | |
66 | 86 | | |
67 | 87 | | |
0 commit comments