Skip to content

Commit 64863bc

Browse files
committed
Review and Javadoc fixes
1 parent 04755c5 commit 64863bc

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

‎server-common/src/main/java/io/a2a/server/tasks/BasePushNotificationSender.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public void sendNotification(StreamingEventKind event) {
108108
* @param event the streaming event
109109
* @return the task ID, or null if not available
110110
*/
111-
private @Nullable String extractTaskId(StreamingEventKind event) {
111+
protected @Nullable String extractTaskId(StreamingEventKind event) {
112112
if (event instanceof Task task) {
113113
return task.id();
114114
} else if (event instanceof Message message) {

‎server-common/src/main/java/io/a2a/server/tasks/PushNotificationSender.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,13 @@ public interface PushNotificationSender {
9191
* Retrieve push notification URLs or messaging configurations from
9292
* {@link PushNotificationConfigStore} using the task ID extracted from the event.
9393
* </p>
94-
* <p>
9594
* Supported event types:
9695
* <ul>
9796
* <li>{@link Task} - wrapped in StreamResponse.task</li>
9897
* <li>{@link io.a2a.spec.Message} - wrapped in StreamResponse.message</li>
9998
* <li>{@link io.a2a.spec.TaskStatusUpdateEvent} - wrapped in StreamResponse.statusUpdate</li>
10099
* <li>{@link io.a2a.spec.TaskArtifactUpdateEvent} - wrapped in StreamResponse.artifactUpdate</li>
101100
* </ul>
102-
* </p>
103101
* <p>
104102
* <b>Error Handling:</b> Log errors but don't throw exceptions. Notifications are
105103
* best-effort and should not fail the primary request.

0 commit comments

Comments
 (0)