Skip to content

Commit a013838

Browse files
committed
build: replace Checkstyle with Spotless (google-java-format)
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
1 parent 05f5d9b commit a013838

1,129 files changed

Lines changed: 160551 additions & 141194 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/build-and-test.yml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,18 @@ concurrency:
1616
cancel-in-progress: true
1717

1818
jobs:
19+
spotless:
20+
runs-on: ubuntu-latest
21+
steps:
22+
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
23+
- name: Set up JDK 21
24+
uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6
25+
with:
26+
java-version: '21'
27+
distribution: 'temurin'
28+
cache: maven
29+
- name: Check formatting with Spotless
30+
run: mvn -B spotless:check -Dskip.spotless=false --file pom.xml
1931
build:
2032
runs-on: ${{ matrix.os }}
2133
strategy:

‎AGENTS.md‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,28 @@ mvn clean install
2020
- `spec-grpc/` — gRPC protobuf definitions and generated classes
2121
- `common/` — Shared utilities used across modules
2222
- `client/` — Client SDK
23-
- `base/` — Core client API
24-
- `transport/spi/` — Transport SPI
25-
- `transport/jsonrpc/`, `transport/grpc/`, `transport/rest/` — Transport implementations
23+
- `base/` — Core client API
24+
- `transport/spi/` — Transport SPI
25+
- `transport/jsonrpc/`, `transport/grpc/`, `transport/rest/` — Transport implementations
2626
- `server-common/` — Server-side core (AgentExecutor, TaskStore, QueueManager)
2727
- `transport/` — Server transport layer (jsonrpc, grpc, rest)
2828
- `http-client/` — HTTP client abstraction
2929
- `jsonrpc-common/` — Shared JSON-RPC utilities
3030
- `reference/` — Reference server implementations built on Quarkus
31-
- `common/`, `jsonrpc/`, `grpc/`, `rest/`
32-
- `multiversion-jsonrpc/`, `multiversion-rest/` — Multi-version dispatching (v1.0 + v0.3)
31+
- `common/`, `jsonrpc/`, `grpc/`, `rest/`
32+
- `multiversion-jsonrpc/`, `multiversion-rest/` — Multi-version dispatching (v1.0 + v0.3)
3333
- `tck/` — Technology Compatibility Kit (protocol conformance tests)
3434
- `tests/` — Integration and server-common tests
35-
- `server-common/` — Server-common integration tests
36-
- `multiversion/` — Multi-version integration tests (jsonrpc, rest, grpc)
35+
- `server-common/` — Server-common integration tests
36+
- `multiversion/` — Multi-version integration tests (jsonrpc, rest, grpc)
3737
- `extras/` — Optional add-ons
38-
- `common/` — Shared classes across extras modules
39-
- `opentelemetry/` — OpenTelemetry integration
40-
- `task-store-database-jpa/` — JPA-backed task store
41-
- `push-notification-config-store-database-jpa/` — JPA-backed push notification config store
42-
- `queue-manager-replicated/` — Kafka-based replicated queue manager
43-
- `http-client-vertx/` — Vert.x HTTP client
44-
- `http-client-android/` — Android HTTP client
38+
- `common/` — Shared classes across extras modules
39+
- `opentelemetry/` — OpenTelemetry integration
40+
- `task-store-database-jpa/` — JPA-backed task store
41+
- `push-notification-config-store-database-jpa/` — JPA-backed push notification config store
42+
- `queue-manager-replicated/` — Kafka-based replicated queue manager
43+
- `http-client-vertx/` — Vert.x HTTP client
44+
- `http-client-android/` — Android HTTP client
4545
- `compat-0.3/` — Backward compatibility layer for A2A protocol v0.3
4646
- `integrations/` — Runtime integrations (e.g., MicroProfile Config)
4747
- `test-utils-docker/` — Test utilities for conditional Docker-based test execution
@@ -117,12 +117,12 @@ mvn quarkus:dev
117117
For detailed architectural documentation:
118118

119119
- **EventQueue & Event Processing**: `.claude/architecture/EVENTQUEUE.md`
120-
- Quick reference with architecture diagram and core components
121-
- **[Queue Lifecycle](.claude/architecture/eventqueue/LIFECYCLE.md)**: Two-level protection, fire-and-forget, late reconnections
122-
- **[Request Flows](.claude/architecture/eventqueue/FLOWS.md)**: Non-streaming vs streaming, cleanup patterns
123-
- **[Usage Scenarios](.claude/architecture/eventqueue/SCENARIOS.md)**: Real-world patterns and common pitfalls
120+
- Quick reference with architecture diagram and core components
121+
- **[Queue Lifecycle](.claude/architecture/eventqueue/LIFECYCLE.md)**: Two-level protection, fire-and-forget, late reconnections
122+
- **[Request Flows](.claude/architecture/eventqueue/FLOWS.md)**: Non-streaming vs streaming, cleanup patterns
123+
- **[Usage Scenarios](.claude/architecture/eventqueue/SCENARIOS.md)**: Real-world patterns and common pitfalls
124124
- **Compatibility with previous protocol versions**:
125-
- 0.3 protocol compatibility layer: `.claude/architecture/compatibility_0.3.md`
125+
- 0.3 protocol compatibility layer: `.claude/architecture/compatibility_0.3.md`
126126

127127
> 💡 Deep-dive docs are loaded on-demand when working in related areas.
128128

‎CODE_OF_CONDUCT.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,20 @@ community include:
2121
* Being respectful of differing opinions, viewpoints, and experiences
2222
* Giving and gracefully accepting constructive feedback
2323
* Accepting responsibility and apologizing to those affected by our mistakes,
24-
and learning from the experience
24+
and learning from the experience
2525
* Focusing on what is best not just for us as individuals, but for the overall
26-
community
26+
community
2727

2828
Examples of unacceptable behavior include:
2929

3030
* The use of sexualized language or imagery, and sexual attention or advances of
31-
any kind
31+
any kind
3232
* Trolling, insulting or derogatory comments, and personal or political attacks
3333
* Public or private harassment
3434
* Publishing others' private information, such as a physical or email address,
35-
without their explicit permission
35+
without their explicit permission
3636
* Other conduct which could reasonably be considered inappropriate in a
37-
professional setting
37+
professional setting
3838

3939
## Enforcement Responsibilities
4040

‎CONTRIBUTING.md‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Welcome to the A2A Java SDK project! We welcome contributions from the community
55

66
- [Forking the Project](#forking-the-project)
77
- [Issues](#issues)
8-
- [Good First Issues](#good-first-issues)
8+
- [Good First Issues](#good-first-issues)
99
- [Setting up your Developer Environment](#setting-up-your-developer-environment)
1010
- [Contributing Guidelines](#contributing-guidelines)
1111
- [Community](#community)
@@ -55,21 +55,21 @@ To set up your development environment you need to:
5555

5656
2. Add a remote ref to upstream, for pulling future updates. For example:
5757

58-
```
59-
git remote add upstream https://github.com/a2aproject/a2a-java
60-
```
58+
```
59+
git remote add upstream https://github.com/a2aproject/a2a-java
60+
```
6161

6262
3. To build `a2a-java` and run the tests, use the following command:
6363

64-
```
65-
mvn clean install
66-
```
64+
```
65+
mvn clean install
66+
```
6767

6868
4. To skip the tests:
6969

70-
```
71-
mvn clean install -DskipTests=true
72-
```
70+
```
71+
mvn clean install -DskipTests=true
72+
```
7373

7474
## Contributing Guidelines
7575

@@ -78,7 +78,7 @@ When submitting a PR, please keep the following guidelines in mind:
7878
1. In general, it's good practice to squash all of your commits into a single commit. For larger changes, it's ok to have multiple meaningful commits. If you need help with squashing your commits, feel free to ask us how to do this on your pull request. We're more than happy to help!
7979

8080
2. Please link the issue you worked on in the description of your pull request and in your commit message. For example, for issue-20, the PR description and commit message could be: ```Add tests to A2AClientTest for sending a task with a FilePart and with a DataPart
81-
Fixes #20```
81+
Fixes #20```
8282

8383
3. Your PR should include tests for the functionality that you are adding.
8484

‎CONTRIBUTING_INTEGRATIONS.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ The pull request should contain a link to your project page.
77
Then the project page itself needs to contain the following information as a minimum:
88

99
* How to use the integration.
10-
* Ideally there should be a sample demonstrating how to use it
10+
* Ideally there should be a sample demonstrating how to use it
1111
* The integration should have tests, extending [AbstractA2AServerTest](tests/server-common/src/test/java/org/a2aproject/sdk/server/apps/common/AbstractA2AServerTest.java)
1212
* The integration should pass the [TCK](https://github.com/a2aproject/a2a-tck), and make it obvious how to see that it has passed.
1313
* Ideally, the integration should be deployed in Maven Central. If that is not possible, provide clear instructions for how to build it.
1414

15-
If some of the above points are problematic, feel free to point that out in your pull request, and we can discuss further. For example, AbstractA2AServerTest is currently written with only the initial runtimes in mind, and might need some tweaking.
15+
If some of the above points are problematic, feel free to point that out in your pull request, and we can discuss further. For example, AbstractA2AServerTest is currently written with only the initial runtimes in mind, and might need some tweaking.

‎README.md‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
<!-- markdownlint-disable no-inline-html -->
66

77
<html>
8-
<h2 align="center">
9-
<img src="https://raw.githubusercontent.com/google-a2a/A2A/refs/heads/main/docs/assets/a2a-logo-black.svg" width="256" alt="A2A Logo"/>
10-
</h2>
11-
<h3 align="center">A Java library that helps run agentic applications as A2A servers following the <a href="https://a2a-protocol.org/">Agent2Agent (A2A) Protocol</a>.</h3>
8+
<h2 align="center">
9+
<img src="https://raw.githubusercontent.com/google-a2a/A2A/refs/heads/main/docs/assets/a2a-logo-black.svg" width="256" alt="A2A Logo"/>
10+
</h2>
11+
<h3 align="center">A Java library that helps run agentic applications as A2A servers following the <a href="https://a2a-protocol.org/">Agent2Agent (A2A) Protocol</a>.</h3>
1212
</html>
1313

1414
A multi-module Maven library providing client and server support for A2A agent communication over JSON-RPC, gRPC, and REST transports.
@@ -32,10 +32,10 @@ Add the A2A Java SDK reference server for JSON-RPC to your Maven project:
3232

3333
```xml
3434
<dependency>
35-
<groupId>org.a2aproject.sdk</groupId>
36-
<artifactId>a2a-java-sdk-reference-jsonrpc</artifactId>
37-
<!-- Use a released version from https://github.com/a2aproject/a2a-java/releases -->
38-
<version>${org.a2aproject.sdk.version}</version>
35+
<groupId>org.a2aproject.sdk</groupId>
36+
<artifactId>a2a-java-sdk-reference-jsonrpc</artifactId>
37+
<!-- Use a released version from https://github.com/a2aproject/a2a-java/releases -->
38+
<version>${org.a2aproject.sdk.version}</version>
3939
</dependency>
4040
```
4141

‎RELEASE.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ Pushing the tag triggers **two workflows**:
135135
2. Extracts version from tag name
136136
3. Generates release notes from commits since last release
137137
4. Creates GitHub release with:
138-
- Auto-generated changelog
139-
- Link to Maven Central artifacts
140-
- Installation instructions
138+
- Auto-generated changelog
139+
- Link to Maven Central artifacts
140+
- Installation instructions
141141

142142
### 8. Verify Deployment
143143

0 commit comments

Comments
 (0)