You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ae3e01b
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: extras/push-notification-config-store-database-jpa/src/main/java/io/a2a/extras/pushnotificationconfigstore/database/jpa/JpaDatabasePushNotificationConfigStore.java
// Keyset pagination: get tasks where timestamp < tokenTimestamp OR (timestamp = tokenTimestamp AND id > tokenId)
89
92
// All tasks have timestamps (TaskStatus canonical constructor ensures this)
90
93
queryBuilder.append(" AND (COALESCE(c.createdAt, :nullSentinel) < :tokenTimestamp OR (COALESCE(c.createdAt, :nullSentinel) = :tokenTimestamp AND c.id.configId > :tokenId))");
91
-
} else {
92
-
// Based on the comments in the test case, if the pageToken is invalid start from the beginning.
93
-
}
94
94
}
95
95
96
96
queryBuilder.append(" ORDER BY COALESCE(c.createdAt, :nullSentinel) DESC, c.id.configId ASC");
@@ -99,22 +99,9 @@ public ListTaskPushNotificationConfigResult getInfo(ListTaskPushNotificationConf
Copy file name to clipboardExpand all lines: extras/push-notification-config-store-database-jpa/src/test/java/io/a2a/extras/pushnotificationconfigstore/database/jpa/JpaDatabasePushNotificationConfigStoreIntegrationTest.java
+5-11Lines changed: 5 additions & 11 deletions
Original file line number
Diff line number
Diff line change
@@ -352,15 +352,12 @@ public void testPaginationWithInvalidToken() {
352
352
// Create 5 configs
353
353
createSamples(taskId, 5);
354
354
355
-
// Request with invalid pageToken - JPA implementation behavior is to start from beginning
355
+
// Request with invalid pageToken - should throw InvalidParamsError for invalid format
Copy file name to clipboardExpand all lines: extras/task-store-database-jpa/src/main/java/io/a2a/extras/taskstore/database/jpa/JpaDatabaseTaskStore.java
+6-19Lines changed: 6 additions & 19 deletions
Original file line number
Diff line number
Diff line change
@@ -25,6 +25,7 @@
25
25
importio.a2a.spec.Artifact;
26
26
importio.a2a.spec.ListTasksParams;
27
27
importio.a2a.spec.Message;
28
+
importio.a2a.util.PageToken;
28
29
importio.a2a.spec.Task;
29
30
importorg.slf4j.Logger;
30
31
importorg.slf4j.LoggerFactory;
@@ -227,23 +228,9 @@ public ListTasksResult list(ListTasksParams params) {
0 commit comments