Skip to content

Commit f75abcf

Browse files
committed
feat!: Update a2a.proto d14f410
based on a2aproject/A2A@d14f410 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
1 parent 659df81 commit f75abcf

58 files changed

Lines changed: 484 additions & 686 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎README.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ public class WeatherAgentCardProducer {
121121
.capabilities(AgentCapabilities.builder()
122122
.streaming(true)
123123
.pushNotifications(false)
124-
.stateTransitionHistory(false)
125124
.build())
126125
.defaultInputModes(Collections.singletonList("text"))
127126
.defaultOutputModes(Collections.singletonList("text"))
@@ -575,10 +574,10 @@ TaskPushNotificationConfig taskConfig = TaskPushNotificationConfig.builder()
575574
.pushNotificationConfig(pushNotificationConfig)
576575
.build();
577576

578-
TaskPushNotificationConfig result = client.setTaskPushNotificationConfiguration(taskConfig);
577+
TaskPushNotificationConfig result = client.createTaskPushNotificationConfiguration(taskConfig);
579578

580579
// You can also optionally specify a ClientCallContext with call-specific config to use
581-
TaskPushNotificationConfig result = client.setTaskPushNotificationConfiguration(taskConfig, clientCallContext);
580+
TaskPushNotificationConfig result = client.createTaskPushNotificationConfiguration(taskConfig, clientCallContext);
582581
```
583582

584583
#### List the push notification configurations for a task

‎client/base/src/main/java/io/a2a/client/AbstractClient.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,26 +224,26 @@ public Task cancelTask(TaskIdParams request) throws A2AClientException {
224224
public abstract Task cancelTask(TaskIdParams request, @Nullable ClientCallContext context) throws A2AClientException;
225225

226226
/**
227-
* Set or update the push notification configuration for a specific task.
227+
* Create or update the push notification configuration for a specific task.
228228
*
229229
* @param request the push notification configuration to set for the task
230230
* @return the configured TaskPushNotificationConfig
231231
* @throws A2AClientException if setting the task push notification configuration fails for any reason
232232
*/
233-
public TaskPushNotificationConfig setTaskPushNotificationConfiguration(
233+
public TaskPushNotificationConfig createTaskPushNotificationConfiguration(
234234
TaskPushNotificationConfig request) throws A2AClientException {
235-
return setTaskPushNotificationConfiguration(request, null);
235+
return createTaskPushNotificationConfiguration(request, null);
236236
}
237237

238238
/**
239-
* Set or update the push notification configuration for a specific task.
239+
* Create or update the push notification configuration for a specific task.
240240
*
241241
* @param request the push notification configuration to set for the task
242242
* @param context optional client call context for the request (may be {@code null})
243243
* @return the configured TaskPushNotificationConfig
244244
* @throws A2AClientException if setting the task push notification configuration fails for any reason
245245
*/
246-
public abstract TaskPushNotificationConfig setTaskPushNotificationConfiguration(
246+
public abstract TaskPushNotificationConfig createTaskPushNotificationConfiguration(
247247
TaskPushNotificationConfig request,
248248
@Nullable ClientCallContext context) throws A2AClientException;
249249

‎client/base/src/main/java/io/a2a/client/Client.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ public Task cancelTask(TaskIdParams request, @Nullable ClientCallContext context
431431
* )
432432
* )
433433
* );
434-
* client.setTaskPushNotificationConfiguration(config);
434+
* client.createTaskPushNotificationConfiguration(config);
435435
* }</pre>
436436
*
437437
* @param request the push notification configuration for the task
@@ -442,9 +442,9 @@ public Task cancelTask(TaskIdParams request, @Nullable ClientCallContext context
442442
* @see PushNotificationConfig
443443
*/
444444
@Override
445-
public TaskPushNotificationConfig setTaskPushNotificationConfiguration(
445+
public TaskPushNotificationConfig createTaskPushNotificationConfiguration(
446446
TaskPushNotificationConfig request, @Nullable ClientCallContext context) throws A2AClientException {
447-
return clientTransport.setTaskPushNotificationConfiguration(request, context);
447+
return clientTransport.createTaskPushNotificationConfiguration(request, context);
448448
}
449449

450450
/**

‎client/base/src/test/java/io/a2a/client/ClientBuilderTest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public class ClientBuilderTest {
3131
.capabilities(AgentCapabilities.builder()
3232
.streaming(true)
3333
.pushNotifications(true)
34-
.stateTransitionHistory(true)
3534
.build())
3635
.defaultInputModes(Collections.singletonList("text"))
3736
.defaultOutputModes(Collections.singletonList("text"))

‎client/transport/grpc/src/main/java/io/a2a/client/transport/grpc/GrpcTransport.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,12 +229,12 @@ public ListTasksResult listTasks(ListTasksParams request, @Nullable ClientCallCo
229229
}
230230

231231
@Override
232-
public TaskPushNotificationConfig setTaskPushNotificationConfiguration(TaskPushNotificationConfig request,
233-
@Nullable ClientCallContext context) throws A2AClientException {
232+
public TaskPushNotificationConfig createTaskPushNotificationConfiguration(TaskPushNotificationConfig request,
233+
@Nullable ClientCallContext context) throws A2AClientException {
234234
checkNotNullParam("request", request);
235235

236236
String configId = request.pushNotificationConfig().id();
237-
io.a2a.grpc.SetTaskPushNotificationConfigRequest grpcRequest = io.a2a.grpc.SetTaskPushNotificationConfigRequest.newBuilder()
237+
io.a2a.grpc.CreateTaskPushNotificationConfigRequest grpcRequest = io.a2a.grpc.CreateTaskPushNotificationConfigRequest.newBuilder()
238238
.setParent("tasks/" + request.taskId())
239239
.setConfig(ToProto.taskPushNotificationConfig(request))
240240
.setConfigId(configId != null ? configId : request.taskId())
@@ -244,7 +244,7 @@ public TaskPushNotificationConfig setTaskPushNotificationConfiguration(TaskPushN
244244

245245
try {
246246
A2AServiceBlockingV2Stub stubWithMetadata = createBlockingStubWithMetadata(context, payloadAndHeaders);
247-
return FromProto.taskPushNotificationConfig(stubWithMetadata.setTaskPushNotificationConfig(grpcRequest));
247+
return FromProto.taskPushNotificationConfig(stubWithMetadata.createTaskPushNotificationConfig(grpcRequest));
248248
} catch (StatusRuntimeException | StatusException e) {
249249
throw GrpcErrorMapper.mapGrpcError(e, "Failed to create task push notification config: ");
250250
}

‎client/transport/jsonrpc/src/main/java/io/a2a/client/transport/jsonrpc/JSONRPCTransport.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import io.a2a.jsonrpc.common.wrappers.ListTasksResponse;
4444
import io.a2a.jsonrpc.common.wrappers.ListTasksResult;
4545
import io.a2a.jsonrpc.common.wrappers.SendMessageResponse;
46-
import io.a2a.jsonrpc.common.wrappers.SetTaskPushNotificationConfigResponse;
46+
import io.a2a.jsonrpc.common.wrappers.CreateTaskPushNotificationConfigResponse;
4747
import io.a2a.spec.A2AClientError;
4848
import io.a2a.spec.A2AClientException;
4949
import io.a2a.spec.A2AError;
@@ -182,15 +182,15 @@ public ListTasksResult listTasks(ListTasksParams request, @Nullable ClientCallCo
182182
}
183183

184184
@Override
185-
public TaskPushNotificationConfig setTaskPushNotificationConfiguration(TaskPushNotificationConfig request,
186-
@Nullable ClientCallContext context) throws A2AClientException {
185+
public TaskPushNotificationConfig createTaskPushNotificationConfiguration(TaskPushNotificationConfig request,
186+
@Nullable ClientCallContext context) throws A2AClientException {
187187
checkNotNullParam("request", request);
188188
PayloadAndHeaders payloadAndHeaders = applyInterceptors(SET_TASK_PUSH_NOTIFICATION_CONFIG_METHOD,
189-
ProtoUtils.ToProto.setTaskPushNotificationConfigRequest(request), agentCard, context);
189+
ProtoUtils.ToProto.CreateTaskPushNotificationConfigRequest(request), agentCard, context);
190190

191191
try {
192192
String httpResponseBody = sendPostRequest(Utils.buildBaseUrl(agentInterface, request.tenant()), payloadAndHeaders, SET_TASK_PUSH_NOTIFICATION_CONFIG_METHOD);
193-
SetTaskPushNotificationConfigResponse response = unmarshalResponse(httpResponseBody, SET_TASK_PUSH_NOTIFICATION_CONFIG_METHOD);
193+
CreateTaskPushNotificationConfigResponse response = unmarshalResponse(httpResponseBody, SET_TASK_PUSH_NOTIFICATION_CONFIG_METHOD);
194194
return response.getResult();
195195
} catch (A2AClientException e) {
196196
throw e;

‎client/transport/jsonrpc/src/test/java/io/a2a/client/transport/jsonrpc/JSONRPCTransportTest.java‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.a2a.client.transport.jsonrpc;
22

3-
import static io.a2a.client.transport.jsonrpc.JsonMessages.AGENT_CARD;
4-
import static io.a2a.client.transport.jsonrpc.JsonMessages.AGENT_CARD_SUPPORTS_EXTENDED;
53
import static io.a2a.client.transport.jsonrpc.JsonMessages.CANCEL_TASK_TEST_REQUEST;
64
import static io.a2a.client.transport.jsonrpc.JsonMessages.CANCEL_TASK_TEST_RESPONSE;
75
import static io.a2a.client.transport.jsonrpc.JsonMessages.GET_AUTHENTICATED_EXTENDED_AGENT_CARD_REQUEST;
@@ -43,7 +41,6 @@
4341
import io.a2a.spec.AgentCard;
4442
import io.a2a.spec.ExtensionSupportRequiredError;
4543
import io.a2a.spec.VersionNotSupportedError;
46-
import io.a2a.spec.AgentInterface;
4744
import io.a2a.spec.AgentSkill;
4845
import io.a2a.spec.Artifact;
4946
import io.a2a.spec.AuthenticationInfo;
@@ -67,7 +64,6 @@
6764
import io.a2a.spec.TaskQueryParams;
6865
import io.a2a.spec.TaskState;
6966
import io.a2a.spec.TextPart;
70-
import io.a2a.spec.TransportProtocol;
7167
import io.a2a.util.Utils;
7268
import org.junit.jupiter.api.AfterEach;
7369
import org.junit.jupiter.api.BeforeEach;
@@ -322,7 +318,7 @@ public void testA2AClientGetTaskPushNotificationConfig() throws Exception {
322318
}
323319

324320
@Test
325-
public void testA2AClientSetTaskPushNotificationConfig() throws Exception {
321+
public void testA2AClientCreateTaskPushNotificationConfig() throws Exception {
326322
this.server.when(
327323
request()
328324
.withMethod("POST")
@@ -337,7 +333,7 @@ public void testA2AClientSetTaskPushNotificationConfig() throws Exception {
337333
);
338334

339335
JSONRPCTransport client = new JSONRPCTransport("http://localhost:4001");
340-
TaskPushNotificationConfig taskPushNotificationConfig = client.setTaskPushNotificationConfiguration(
336+
TaskPushNotificationConfig taskPushNotificationConfig = client.createTaskPushNotificationConfiguration(
341337
new TaskPushNotificationConfig("de38c76d-d54c-436c-8b9f-4c2703648d64",
342338
PushNotificationConfig.builder()
343339
.id("c295ea44-7543-4f78-b524-7a38915ad6e4")
@@ -378,7 +374,6 @@ public void testA2AClientGetExtendedAgentCard() throws Exception {
378374
assertEquals("https://docs.examplegeoservices.com/georoute-agent/api", agentCard.documentationUrl());
379375
assertTrue(agentCard.capabilities().streaming());
380376
assertTrue(agentCard.capabilities().pushNotifications());
381-
assertFalse(agentCard.capabilities().stateTransitionHistory());
382377
assertTrue(agentCard.capabilities().extendedAgentCard());
383378
Map<String, SecurityScheme> securitySchemes = agentCard.securitySchemes();
384379
assertNotNull(securitySchemes);

‎client/transport/jsonrpc/src/test/java/io/a2a/client/transport/jsonrpc/JsonMessages.java‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public class JsonMessages {
2828
"capabilities": {
2929
"streaming": true,
3030
"pushNotifications": true,
31-
"stateTransitionHistory": false,
3231
"extendedAgentCard": false
3332
},
3433
"securitySchemes": {
@@ -340,7 +339,7 @@ public class JsonMessages {
340339
static final String SET_TASK_PUSH_NOTIFICATION_CONFIG_TEST_REQUEST = """
341340
{
342341
"jsonrpc":"2.0",
343-
"method":"SetTaskPushNotificationConfig",
342+
"method":"CreateTaskPushNotificationConfig",
344343
"params":{
345344
"parent":"tasks/de38c76d-d54c-436c-8b9f-4c2703648d64",
346345
"configId":"c295ea44-7543-4f78-b524-7a38915ad6e4",
@@ -610,7 +609,6 @@ public class JsonMessages {
610609
"capabilities": {
611610
"streaming": true,
612611
"pushNotifications": true,
613-
"stateTransitionHistory": false,
614612
"extendedAgentCard": true
615613
},
616614
"securitySchemes": {
@@ -691,7 +689,6 @@ public class JsonMessages {
691689
"capabilities": {
692690
"streaming": true,
693691
"pushNotifications": true,
694-
"stateTransitionHistory": false,
695692
"extendedAgentCard": true
696693
},
697694
"securitySchemes": {

‎client/transport/rest/src/main/java/io/a2a/client/transport/rest/RestTransport.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,10 @@ private String buildListTasksQueryString(ListTasksParams request) {
269269
}
270270

271271
@Override
272-
public TaskPushNotificationConfig setTaskPushNotificationConfiguration(TaskPushNotificationConfig request, @Nullable ClientCallContext context) throws A2AClientException {
272+
public TaskPushNotificationConfig createTaskPushNotificationConfiguration(TaskPushNotificationConfig request, @Nullable ClientCallContext context) throws A2AClientException {
273273
checkNotNullParam("request", request);
274-
io.a2a.grpc.SetTaskPushNotificationConfigRequest.Builder builder
275-
= io.a2a.grpc.SetTaskPushNotificationConfigRequest.newBuilder();
274+
io.a2a.grpc.CreateTaskPushNotificationConfigRequest.Builder builder
275+
= io.a2a.grpc.CreateTaskPushNotificationConfigRequest.newBuilder();
276276
builder.setConfig(ProtoUtils.ToProto.taskPushNotificationConfig(request))
277277
.setParent("tasks/" + request.taskId());
278278
if (request.pushNotificationConfig().id() != null) {

‎client/transport/rest/src/test/java/io/a2a/client/transport/rest/JsonRestMessages.java‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,7 @@ public class JsonRestMessages {
121121
"documentationUrl": "https://docs.examplegeoservices.com/georoute-agent/api",
122122
"capabilities": {
123123
"streaming": true,
124-
"pushNotifications": true,
125-
"stateTransitionHistory": false
124+
"pushNotifications": true
126125
},
127126
"securitySchemes": {
128127
"google": {
@@ -188,8 +187,7 @@ public class JsonRestMessages {
188187
"documentationUrl": "https://docs.examplegeoservices.com/georoute-agent/api",
189188
"capabilities": {
190189
"streaming": true,
191-
"pushNotifications": true,
192-
"stateTransitionHistory": false
190+
"pushNotifications": true
193191
},
194192
"securitySchemes": {
195193
"google": {
@@ -255,8 +253,7 @@ public class JsonRestMessages {
255253
"documentationUrl": "https://docs.examplegeoservices.com/georoute-agent/api",
256254
"capabilities": {
257255
"streaming": true,
258-
"pushNotifications": true,
259-
"stateTransitionHistory": false
256+
"pushNotifications": true
260257
},
261258
"securitySchemes": {
262259
"google": {

0 commit comments

Comments
 (0)