Skip to content

Add a test to JSONRPCHandlerTest for sending a streaming message where multiple events are received from the server #52

Closed

Description

@fjuma

The existing JSONRPCHandlerTest only tests the case where one event is received when sending a streaming message (e.g., see testOnMessageStreamNewMessageSuccess and notice that only one event is enqueued by the server and received by the client).

We should also test the case where multiple events are received when sending a streaming message.

Activity

  1. changed the title [-]Add a test for A2AClient#sendStreamingMessage where multiple events are received from the server[/-] [+]Add a test to JSONRPCHandlerTest for sending a streaming message where multiple events are received from the server[/+] on Sep 22, 2025
  2. misysin commented on Oct 2, 2025

    @misysin
    Contributor

    Hi @fjuma , I’d like to take this one up. Can you assign this to me? Thanks :)

  3. kabir commented on Oct 2, 2025

    @kabir
    Collaborator

    @amithsourya done - thanks :-)

  4. added a commit that references this issue on Oct 4, 2025
    806feb2
  5. misysin commented on Oct 4, 2025

    @misysin
    Contributor

    Hey @kabir @fjuma 👋

    PR #326 is up and ready for review!

    Had a blast working on this and learned tons about the A2A protocol
    Would love to keep contributing if there are other issues that could use some help

  6. kabir commented on Oct 9, 2025

    @kabir
    Collaborator

    @amithsourya That would be great :-) I've been focussed on a tricky problem the past few days, but will open some issues once I start looking at other stuff again. Or just comment on any open issue you feel like doing?

  7. added a commit that references this issue on Oct 9, 2025
    09c625f
  8. misysin commented on Oct 9, 2025

    @misysin
    Contributor

    @kabir Great! I'll check out the open issues.
    Out of curiosity, what's the tricky problem you're working on? I love solving tough puzzles, so if there's any way I could contribute ideas or just follow along to learn, I'd be interested!

    Also, is there a Slack/Discord/chat for the project? Would be great to be part of any ongoing discussions!

  9. kabir commented on Oct 10, 2025

    @kabir
    Collaborator

    @amithsourya the first part was this #331. Although in its final form it doesn't look like much, the journey to get here was quite eventful with each fix breaking something else :-D

    I am working on another PR which tightens this up further to try to resolve the occasionally failing Kafka test

  10. kabir commented on Oct 10, 2025

    @kabir
    Collaborator

    Hi, @amithsourya the whole A2A project uses Discord for discussions. https://discord.gg/aGCW27RK We are in #sdk-java.

  11. misysin commented on Oct 10, 2025

    @misysin
    Contributor

    Thanks a lot @kabir Just joined the Discord.
    Appreciate you sharing the PR. It sounds like quite a ride 😄
    I'll go through it and learn from how you tackled it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions