Repository navigation
test(compat-0.3): cover null part metadata conversions - #1289
Merged
Merged
Conversation
Add regression coverage for text and data metadata conversion and defensive copying. The runtime fix is already in a2aproject#1261. Related to a2aproject#1275. Signed-off-by: Japneet Singh <japneet.singh2024@gmail.com>
Collaborator
|
Thanks @Orcus01 ! |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add regression coverage related to #1275: null metadata values when converting parts between v1.0 and v0.3.
The runtime fix is already merged in #1261 and included in 1.5.0.Final. This PR adds tests only:
Temporarily restoring the two constructors from before #1261 reproduces the reported NPE in both new constructor regression cases. Current production code is unchanged.
Validation
git diff --check— passed.Test command:
mvn -B -pl compat-0.3/server-conversion -am test -Dtest=NullValues_v0_3_Test,NullData_v0_3_Test,JSONRPCErrorSerialization_v0_3_Test,SubTypeSerialization_v0_3_Test,TaskSerialization_v0_3_Test,TaskMapper_v0_3_Test,TaskStatusUpdateEventMapper_v0_3_Test,FileContentMapper_v0_3_Test -Dsurefire.failIfNoSpecifiedTests=falseRelated to #1275. Suggested English issue title: "[Bug]: Null metadata values cause NPEs when converting parts between v1.0 and v0.3".