Repository navigation
fix: Make historyLength consistent with pageSize in mapper - #600
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an inconsistency in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly updates the historyLength mapping in ListTasksParamsMapper.java to align with how pageSize is handled. By using request.hasHistoryLength(), the mapper now accurately distinguishes between an unset historyLength field (which maps to null) and an explicitly provided 0 value (which maps to 0). This change improves consistency and semantic correctness when converting Protobuf ListTasksRequest to the domain ListTasksParams, especially since 0 is a valid non-negative value for historyLength in the domain model.
No description provided.