Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
awaitcall is placed aftergetClient().sendMessage(...), which doesn't fully resolve the race condition. ThesendMessagecall triggers the agent to send events immediately. These events could be sent and missed by the client before thisawaitcompletes, especially if the client-side consumer is not fully wired up.To reliably fix this, you should wait for the subscription to be established before triggering the agent. The
awaitshould be beforesendMessage. I've suggested this change below.However, this will likely lead to a deadlock, as
sendMessageis what triggers the subscription creation thatawaitStreamingSubscriptionis waiting for. This indicates a deeper issue with the test's design or thesendMessageAPI, which might need a more comprehensive fix to allow waiting for the subscription to be ready before events are generated.