Repository navigation
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the management of Jakarta EE dependencies by leveraging the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors dependency management to use the Jakarta EE BOM, which is a great improvement for consistency and maintainability. The changes correctly introduce jakarta.jakartaee-bom in the SDK's public BOM and rely on the existing quarkus-bom for the internal project build, cleaning up redundant version properties and explicit dependencies.
I've found one potential issue in the public a2a-java-sdk-bom where removing the explicit management for some Jakarta APIs also removes their scope=provided default, which could be a breaking change for consumers. A detailed comment with a suggestion is provided.
The other additions to the BOM (gson, junit-jupiter, mockito-junit-jupiter) are good enhancements for dependency management, even if slightly outside the scope of the main change.
| <version>${gson.version}</version> | ||
| </dependency> | ||
|
|
||
| <!-- Jakarta APIs managed by Jakarta Platform BOM --> |
There was a problem hiding this comment.
While using the Jakarta EE BOM is a good step, removing the explicit dependency declarations for jakarta.json-api and jakarta.ws.rs-api also removes their <scope>provided</scope>. The imported jakarta.jakartaee-bom only manages versions, not scopes. This means consumers of this BOM who depend on these APIs without specifying a scope will now get them with the default compile scope instead of provided. This is likely not the intended behavior and could be a breaking change for consumers of the SDK BOM.
It's recommended to retain the declarations for these APIs to enforce the correct scope, while letting the BOM manage the versions. You can re-add them without the <version> tag.
<!-- Jakarta APIs managed by Jakarta Platform BOM -->
<dependency>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-api</artifactId>
</dependency>
<dependency>
<groupId>jakarta.inject</groupId>
<artifactId>jakarta.inject-api</artifactId>
</dependency>
<dependency>
<groupId>jakarta.json</groupId>
<artifactId>jakarta.json-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>jakarta.ws.rs</groupId>
<artifactId>jakarta.ws.rs-api</artifactId>
<scope>provided</scope>
</dependency>
No description provided.