Skip to content

fix!: Rename ListTaskPushNotificationConfig to plural `ListTaskPush… - #724

Merged
kabir merged 1 commit into
a2aproject:mainfrom
ehsavoie:issue_704
Mar 12, 2026
Merged

kabir merged 1 commit into
a2aproject:mainfrom
ehsavoie:issue_704

Conversation

@ehsavoie

Copy link
Copy Markdown
Collaborator

…NotificationConfigs` for consistency

Fixes #704 🦕

@ehsavoie
ehsavoie requested review from jmesnil and kabir March 11, 2026 17:45
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting /gemini summary.

@ehsavoie

Copy link
Copy Markdown
Collaborator Author

/gemin review

@ehsavoie

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly renames ListTaskPushNotificationConfig and related classes to their plural form ListTaskPushNotificationConfigs for better consistency, as the operation deals with a list of configurations. The changes are applied consistently across the codebase, including method signatures, variable names, and documentation. I've found one minor inconsistency in an error message which I've commented on. Overall, this is a good improvement for code clarity.

…NotificationConfigs` for consistency

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@kabir
kabir merged commit 5be57f0 into a2aproject:main Mar 12, 2026
11 checks passed
salaboy pushed a commit to salaboy/a2a-java that referenced this pull request Jun 19, 2026
a2aproject#724)

…NotificationConfigs` for consistency

Fixes a2aproject#704 🦕

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie
ehsavoie deleted the issue_704 branch July 28, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Use consistent names for listTaskPushNotificationConfigs

2 participants