@@ -534,8 +534,11 @@ async def test_save_task_event_stamps_terminal_status_without_timestamp(
534534
535535
536536@pytest .mark .asyncio
537- async def test_save_task_event_preserves_provided_terminal_timestamp (
538- task_manager : TaskManager , mock_task_store : AsyncMock
537+ @pytest .mark .parametrize (
538+ 'state' , [TaskState .TASK_STATE_FAILED , TaskState .TASK_STATE_WORKING ]
539+ )
540+ async def test_save_task_event_preserves_provided_timestamp (
541+ task_manager : TaskManager , mock_task_store : AsyncMock , state : int
539542) -> None :
540543 """An explicitly provided timestamp is never overwritten (#1331)."""
541544 initial_task = create_minimal_task ()
@@ -545,9 +548,7 @@ async def test_save_task_event_preserves_provided_terminal_timestamp(
545548 event = TaskStatusUpdateEvent (
546549 task_id = MINIMAL_TASK_ID ,
547550 context_id = MINIMAL_CONTEXT_ID ,
548- status = TaskStatus (
549- state = TaskState .TASK_STATE_FAILED , timestamp = provided
550- ),
551+ status = TaskStatus (state = state , timestamp = provided ),
551552 )
552553
553554 await task_manager .save_task_event (event )
@@ -559,37 +560,105 @@ async def test_save_task_event_preserves_provided_terminal_timestamp(
559560
560561
561562@pytest .mark .asyncio
562- async def test_save_task_event_does_not_stamp_non_terminal_status (
563- task_manager : TaskManager , mock_task_store : AsyncMock
563+ @pytest .mark .parametrize (
564+ 'state' ,
565+ [
566+ TaskState .TASK_STATE_WORKING ,
567+ TaskState .TASK_STATE_INPUT_REQUIRED ,
568+ TaskState .TASK_STATE_AUTH_REQUIRED ,
569+ ],
570+ )
571+ async def test_save_task_event_stamps_non_terminal_status (
572+ task_manager : TaskManager , mock_task_store : AsyncMock , state : int
564573) -> None :
565- """Non-terminal states are left alone by the backstop (#1331) ."""
574+ """Non-terminal status updates receive timestamps too ."""
566575 initial_task = create_minimal_task ()
567576 mock_task_store .get .return_value = initial_task
568577 event = TaskStatusUpdateEvent (
569578 task_id = MINIMAL_TASK_ID ,
570579 context_id = MINIMAL_CONTEXT_ID ,
571- status = TaskStatus (state = TaskState . TASK_STATE_WORKING ),
580+ status = TaskStatus (state = state ),
572581 )
573582
574583 await task_manager .save_task_event (event )
575584
576585 saved_task = mock_task_store .save .call_args [0 ][0 ]
577- assert saved_task .status .state == TaskState .TASK_STATE_WORKING
578- assert not saved_task .status .HasField ('timestamp' )
586+ assert saved_task .status .state == state
587+ assert saved_task .status .HasField ('timestamp' )
588+ assert event .status .timestamp == saved_task .status .timestamp
589+
590+
591+ @pytest .mark .asyncio
592+ async def test_ensure_task_id_stamps_initial_submitted_status (
593+ task_manager : TaskManager , mock_task_store : AsyncMock
594+ ) -> None :
595+ mock_task_store .get .return_value = None
596+
597+ task = await task_manager .ensure_task_id (
598+ MINIMAL_TASK_ID , MINIMAL_CONTEXT_ID
599+ )
600+
601+ assert task .status .state == TaskState .TASK_STATE_SUBMITTED
602+ assert task .status .HasField ('timestamp' )
603+ saved_task = mock_task_store .save .call_args [0 ][0 ]
604+ assert saved_task .status .timestamp == task .status .timestamp
579605
580606
581607@pytest .mark .asyncio
582- async def test_save_task_event_stamps_raw_failed_task_without_timestamp (
608+ async def test_artifact_first_stamps_initial_status (
583609 task_manager : TaskManager , mock_task_store : AsyncMock
584610) -> None :
585- """The raw-Task path (direct mutation failure sites) is guarded too
586- (#1331)."""
587- failing_task = create_minimal_task ()
588- failing_task .status .state = TaskState .TASK_STATE_FAILED
611+ mock_task_store .get .return_value = None
612+ event = TaskArtifactUpdateEvent (
613+ task_id = MINIMAL_TASK_ID ,
614+ context_id = MINIMAL_CONTEXT_ID ,
615+ artifact = Artifact (
616+ artifact_id = 'artifact-1' , parts = [Part (text = 'result' )]
617+ ),
618+ )
619+
620+ task = await task_manager .save_task_event (event )
621+
622+ assert task is not None
623+ assert task .status .state == TaskState .TASK_STATE_SUBMITTED
624+ assert task .status .HasField ('timestamp' )
625+ assert (
626+ mock_task_store .save .call_args [0 ][0 ].status .timestamp
627+ == task .status .timestamp
628+ )
629+
630+
631+ @pytest .mark .asyncio
632+ async def test_raw_working_task_preserves_provided_timestamp (
633+ task_manager : TaskManager ,
634+ ) -> None :
635+ task = create_minimal_task ()
636+ task .status .state = TaskState .TASK_STATE_WORKING
637+ task .status .timestamp .FromDatetime (
638+ datetime (2026 , 1 , 1 , tzinfo = timezone .utc )
639+ )
640+ expected = Timestamp ()
641+ expected .CopyFrom (task .status .timestamp )
642+
643+ await task_manager .save_task_event (task )
644+
645+ assert task .status .timestamp == expected
646+
647+
648+ @pytest .mark .asyncio
649+ @pytest .mark .parametrize (
650+ 'state' , [TaskState .TASK_STATE_FAILED , TaskState .TASK_STATE_WORKING ]
651+ )
652+ async def test_save_task_event_stamps_raw_task_without_timestamp (
653+ task_manager : TaskManager , mock_task_store : AsyncMock , state : int
654+ ) -> None :
655+ """Raw task status updates receive timestamps for any state."""
656+ task = create_minimal_task ()
657+ task .status .state = state
589658
590- returned = await task_manager .save_task_event (failing_task )
659+ returned = await task_manager .save_task_event (task )
591660
592- assert returned .status .state == TaskState . TASK_STATE_FAILED
661+ assert returned .status .state == state
593662 assert returned .status .HasField ('timestamp' )
594663
595664
0 commit comments